Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of manually setting --enable/disable-static/shared flags #51540

Open
matthewbauer opened this issue Dec 5, 2018 · 7 comments
Open

Get rid of manually setting --enable/disable-static/shared flags #51540

matthewbauer opened this issue Dec 5, 2018 · 7 comments
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md

Comments

@matthewbauer
Copy link
Member

matthewbauer commented Dec 5, 2018 •
edited

Issue description

We shouldn't be setting these flags in configureFlags. Packages built in nixpkgs should all have set:

  • --disable-static
  • --enable-shared

This is done automatically. Some places are setting this manually:

https://github.com/NixOS/nixpkgs/search?q=--enable-static
https://github.com/NixOS/nixpkgs/search?q=--disable-static
https://github.com/NixOS/nixpkgs/search?q=--enable-shared
https://github.com/NixOS/nixpkgs/search?q=--enable-shared

Most likely something else is going on that needs to be investigated.
@matthewbauer matthewbauer changed the title Get rid of --enable/disable-static/shared flags Get rid of manually setting --enable/disable-static/shared flags Dec 5, 2018
@jtojnar
Copy link
Contributor

jtojnar commented Dec 5, 2018 •
edited

We probably should do the same thing with CMake and -DBUILD_SHARED_LIBS=ON.

@nh2
Copy link
Contributor

nh2 commented Apr 13, 2019

This sounds like a good idea to me.

Are there any drawbacks?

Otherwise let's do it.

nh2 added a commit to nh2/nixpkgs that referenced this issue Aug 12, 2019
@nh2
libimobiledevice: Remove unnecessary --disable-static.
3c2c3f0 
That's already controlled by `dontDisableStatic`, see:

* https://nixos.org/nixpkgs/manual/#ssec-configure-phase
* NixOS#51540
@stale
Copy link

stale bot commented Jun 3, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2020
@nh2
Copy link
Contributor

nh2 commented Jun 3, 2020

still important to me

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2020
@stale
Copy link

stale bot commented Nov 30, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 30, 2020
@nh2
Copy link
Contributor

nh2 commented Dec 3, 2020

still

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 3, 2020
@stale
Copy link

stale bot commented Jun 2, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matthewbauer @nh2 @jtojnar