Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.neovim-0.3.0 -> pythonPackages.pynvim-0.3.1 #51758

Merged
merged 3 commits into from
Dec 12, 2018

Conversation

rasendubi
Copy link
Member

Motivation for this change

The package has been renamed to pynvim.

https://github.com/neovim/pynvim/releases/tag/0.3.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc neovim maintainers @garbas @manveru @rvolosatovs

@rasendubi
Copy link
Member Author

Tested with nix-review—all good.

6 package were build:
neovim neovim-pygui neovim-qt neovim-remote python27Packages.pynvim python37Packages.pynvim

@GrahamcOfBorg neovim neovim-pygui neovim-qt neovim-remote python27Packages.pynvim python37Packages.pynvim

@Mic92
Copy link
Member

Mic92 commented Dec 8, 2018

@GrahamcOfBorg build neovim neovim-pygui neovim-qt neovim-remote python27Packages.pynvim python37Packages.pynvim

@Mic92
Copy link
Member

Mic92 commented Dec 8, 2018

Indeed I already thought about printing the correct ofborg line in nix-review.

@rasendubi
Copy link
Member Author

Oops, missed build. Thanks for fixing!

sha256 = "1gia7ksyf8x7lkawrslq3ppv6k0hpp87q19g3hi28fl7lhh17kjn";
})
];

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like your patch was accepted upstream. Can we bump the gui instead of patching it ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They didn't release a new version, so bumping gui requires pinning to a specific commit and switching to "unstable" version.

Given the project is abandoned I wonder if anyone uses it at all? (i.e., do we still need to package it, or it is safe to drop?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can drop it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the python neovim gui is mostly the experimental GUI where neovim devs (mostly bjorn) make sure the UI features actually work in a sensible way. It's not supposed to be used really so it can be dropped. I might save the recipe into my overlay though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info! I've dropped it.

@rasendubi
Copy link
Member Author

@GrahamcOfBorg build neovim neovim-qt neovim-remote python27Packages.pynvim python37Packages.pynvim

@rasendubi
Copy link
Member Author

@garbas @manveru @rvolosatovs @Mic92 the PR should be all good now. Anyone willing to review/merge it?

@Mic92 Mic92 merged commit f49e2ad into NixOS:master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants