-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.neovim-0.3.0 -> pythonPackages.pynvim-0.3.1 #51758
Conversation
Tested with nix-review—all good.
@GrahamcOfBorg neovim neovim-pygui neovim-qt neovim-remote python27Packages.pynvim python37Packages.pynvim |
@GrahamcOfBorg build neovim neovim-pygui neovim-qt neovim-remote python27Packages.pynvim python37Packages.pynvim |
Indeed I already thought about printing the correct ofborg line in |
Oops, missed |
sha256 = "1gia7ksyf8x7lkawrslq3ppv6k0hpp87q19g3hi28fl7lhh17kjn"; | ||
}) | ||
]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like your patch was accepted upstream. Can we bump the gui instead of patching it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They didn't release a new version, so bumping gui requires pinning to a specific commit and switching to "unstable" version.
Given the project is abandoned I wonder if anyone uses it at all? (i.e., do we still need to package it, or it is safe to drop?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can drop it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the python neovim gui is mostly the experimental GUI where neovim devs (mostly bjorn) make sure the UI features actually work in a sensible way. It's not supposed to be used really so it can be dropped. I might save the recipe into my overlay though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the info! I've dropped it.
@GrahamcOfBorg build neovim neovim-qt neovim-remote python27Packages.pynvim python37Packages.pynvim |
@garbas @manveru @rvolosatovs @Mic92 the PR should be all good now. Anyone willing to review/merge it? |
Motivation for this change
The package has been renamed to pynvim.
https://github.com/neovim/pynvim/releases/tag/0.3.1
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)/cc neovim maintainers @garbas @manveru @rvolosatovs