Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toggldesktop: fails to build #53676

Closed
neilmayhew opened this issue Jan 8, 2019 · 2 comments
Closed

toggldesktop: fails to build #53676

neilmayhew opened this issue Jan 8, 2019 · 2 comments
Labels
6.topic: qt/kde

Comments

@neilmayhew
Copy link
Member

Issue description

toggldesktop fails to build.

Steps to reproduce

https://hydra.nixos.org/job/nixpkgs/trunk/toggldesktop.x86_64-linux

Technical details

The build error is in an internal dependency, qt-oauth-lib. The nix derivation uses the upstream version from Github but Toggl is actually using a vendored internal version that has a number of fixes in it. The build error is due to using the discontinued QtWebKit library. Toggl's internal version uses QtWebEngine. This problem has been noted in #53079.
@veprbl
Copy link
Member

veprbl commented Jan 25, 2019

cc @yegortimoshenko

@lukateras lukateras mentioned this issue Jan 25, 2019
Merged
10 tasks
@lukateras
Copy link
Member

Fixed in yegortimoshenko/oauth2-qt@60576a4 (tagged 20190125.190943).

See #54587 for Nixpkgs PR.

veprbl added a commit that referenced this issue Jan 25, 2019
@veprbl
Merge pull request #54587 from transumption/201901/qt-oauth-lib
6f5bb35 
toggldesktop: bump qt-oauth-lib (see #53676)
danbst pushed a commit to danbst/nixpkgs that referenced this issue Jan 31, 2019
@lukateras @danbst
toggldesktop: bump qt-oauth-lib (see NixOS#53676)
87ff863
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
6.topic: qt/kde
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@neilmayhew @veprbl @lukateras