Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libreoffice-fresh: doesn't build on master #53921

Closed
pbogdan opened this issue Jan 14, 2019 · 5 comments
Closed

libreoffice-fresh: doesn't build on master #53921

pbogdan opened this issue Jan 14, 2019 · 5 comments
Assignees
@vcunat
Labels
0.kind: regression Something that worked before working no longer

Comments

@pbogdan
Copy link
Member

pbogdan commented Jan 14, 2019

Issue description

Per issue title libreoffice-fresh doesn't build on master - https://hydra.nixos.org/build/87254766/nixlog/1. As far as I can tell this is due to upstream incompatibility with newer poppler. Upstream master appears to contain fixes for poppler up to 0.72 but not 0.73. Those don't apply cleanly to 6.1.4.2 (latest upstream release AFAICT).

Steps to reproduce

$ nix-build -A libreoffice-fresh

Technical details

Nixpkgs master.
@pbogdan
Copy link
Member Author

pbogdan commented Jan 14, 2019

For reference my local fixes are in master...pbogdan:lo-fresh-update

@vcunat
Copy link
Member

vcunat commented Jan 14, 2019

/cc maintainer @7c6f434c.

Nitpick: perhaps fetchpatch instead of copying it into nixpkgs, if it isn't too much trouble.

@vcunat
Copy link
Member

vcunat commented Jan 14, 2019

I confirm that after applying c5b14cf87b42cf4, libreoffice-fresh builds and starts (x86_64 NixOS).

@7c6f434c
Copy link
Member

@vcunat thanks for the ping (id did stash away the notification in email, but hadn't force-watched the issue yet).

Will you merge the exact change as you tested or should I do it? I guess 0.73 fixing some more bugs around broken files is useful…

@hedning hedning added the 0.kind: regression Something that worked before working no longer label Jan 14, 2019
@vcunat vcunat self-assigned this Jan 16, 2019
@vcunat
Copy link
Member

vcunat commented Jan 16, 2019 •
edited

I failed to find a downloadable version of the patch quickly, so I pushed it as it was. A few kB isn't that much.

@vcunat vcunat closed this as completed Jan 16, 2019
vcunat pushed a commit that referenced this issue Jan 16, 2019
@pbogdan @vcunat
libreoffice-fresh: 6.1.3.2 -> 6.1.4.2
c16b33b 
And patch it, together fixing build with new poppler.
Fixes #53921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vcunat vcunat

Labels
0.kind: regression Something that worked before working no longer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hedning @pbogdan @vcunat @7c6f434c