Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome-keyring test failure on staging #55293

Closed
worldofpeace opened this issue Feb 6, 2019 · 5 comments
Closed

gnome-keyring test failure on staging #55293

worldofpeace opened this issue Feb 6, 2019 · 5 comments
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform

Comments

@worldofpeace
Copy link
Contributor

Issue description

See: https://hydra.nixos.org/build/88208186

@worldofpeace worldofpeace added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Feb 6, 2019
@hedning
Copy link
Contributor

hedning commented Feb 6, 2019

I'm not able to reproduce the exact test failure. The first build I tried failed a test, the second passed. So that should confirm our suspicion that the tests can fail sometimes.

@worldofpeace
Copy link
Contributor Author

I'm not able to reproduce the exact test failure. The first build I tried failed a test, the second passed. So that should confirm our suspicion that the tests can fail sometimes.

I guess that means they're pretty flaky, and something we should be fixing upstream.

If they cause consistent problems we should just disable them.

@worldofpeace
Copy link
Contributor Author

Ah looks like we've seen this before in:

@hedning
Copy link
Contributor

hedning commented Feb 6, 2019

Looks like fedora doesn't run the check phase, arch runs it but doesn't record the failure. So I'm guessing we should turn checking off.

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Feb 6, 2019

I agree, also looks like checks for gcr and libsecret are disabled in nixpkgs.

This change is incoming shortly.

worldofpeace added a commit that referenced this issue Feb 6, 2019
Seen these fail non-deterministically at a high enough frequency
making it a good contender to disable completely.

See also #55293, #51121.

cc @hedning @jtojnar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform
Projects
None yet
Development

No branches or pull requests

2 participants