Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glibcLocales should include C.UTF-8 #57974

Closed
FRidh opened this issue Mar 20, 2019 · 4 comments
Closed

glibcLocales should include C.UTF-8 #57974

FRidh opened this issue Mar 20, 2019 · 4 comments
Milestone
19.03

Comments

@FRidh
Copy link
Member

FRidh commented Mar 20, 2019

Issue description

Support for C.UTF-8 was added to glibc, however, not to glibcLocales. Including glibcLocales as a buildInput or during run-time may break LANG=C.UTF-8 as mentioned in #56347 (comment) and #57911.

Steps to reproduce

Technical details

Please run nix-shell -p nix-info --run "nix-info -m" and paste the
results.

cc @Mic92
@FRidh FRidh added this to the 19.03 milestone Mar 20, 2019
@FRidh FRidh mentioned this issue Mar 20, 2019
Closed
@Mic92
Copy link
Member

Mic92 commented Mar 20, 2019

Yeah. Make sense to add it to glibcLocales too. I had the intention it would actually look in both places. But maybe this is not the case if LOCALE_ARCHIVE is exported as environment variable.

Mic92 added a commit to Mic92/nixpkgs that referenced this issue Mar 21, 2019
@Mic92
glibcLocales: also build C.UTF-8
467f0f9 
Previously we only build C.UTF-8 as part of the locale-archive
that comes with the glibc core package.
However for consistent use of LANG=C.UTF-8 we also want support
in our glibcLocales as well.
fixes NixOS#57974
@Mic92 Mic92 mentioned this issue Mar 21, 2019
Merged
10 tasks
@Mic92
Copy link
Member

Mic92 commented Mar 21, 2019

Also checkout #58009

Mic92 added a commit that referenced this issue Mar 21, 2019
@Mic92
glibcLocales: also build C.UTF-8
1db1951 
Previously we only build C.UTF-8 as part of the locale-archive
that comes with the glibc core package.
However for consistent use of LANG=C.UTF-8 we also want support
in our glibcLocales as well.
fixes #57974

(cherry picked from commit 467f0f9)
@Mic92
Copy link
Member

Mic92 commented Mar 21, 2019

This is fixed in staging and staging-19.03.

@Mic92 Mic92 closed this as completed Mar 21, 2019
@FRidh
Copy link
Member Author

FRidh commented Mar 23, 2019

Great, thanks!

@bachp bachp mentioned this issue Apr 2, 2019
Closed
@bb010g bb010g mentioned this issue Apr 6, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
19.03
Development

No branches or pull requests
2 participants
@Mic92 @FRidh