Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python36Packages.jsbeautifier is failing on master and 19.03 #58608

Closed
kalbasit opened this issue Mar 31, 2019 · 3 comments
Closed

python36Packages.jsbeautifier is failing on master and 19.03 #58608

kalbasit opened this issue Mar 31, 2019 · 3 comments
Milestone

Comments

@kalbasit
Copy link
Member

Issue description

python36Packages.jsbeautifier build is failing, the same error occurs on master and 19.03. Updating the package 1.8.9 -> 1.9.1 does not solve the problem.

Steps to reproduce

$ nix-shell -p nur.repos.kalbasit.nix-verify --run 'nix-verify -I nixpkgs=`pwd` -A python36Packages.jsbeautifier'
$ exec env -i NIXPKGS_ALLOW_UNFREE=1 nix-build -I nixpkgs=/yl/code/opensource/stories/nixpkgs_fix-js-beautifier/src/github.com/NixOS/nixpkgs -A python36Packages.jsbeautifier
these derivations will be built:
  /nix/store/967sjl11npm9gnbcsd46i7drpbiy5r4d-jsbeautifier-1.8.9.drv
building '/nix/store/967sjl11npm9gnbcsd46i7drpbiy5r4d-jsbeautifier-1.8.9.drv' on 'ssh://builder@zeus.home.nasreddine.com'...
unpacking sources
unpacking source archive /nix/store/sra58bakragbm410y5hgrhm9bim3irf1-jsbeautifier-1.8.9.tar.gz
source root is jsbeautifier-1.8.9
setting SOURCE_DATE_EPOCH to timestamp 1544134035 of file jsbeautifier-1.8.9/setup.cfg
patching sources
configuring
building
running bdist_wheel

[... SNIP ..]

running test
running egg_info
writing jsbeautifier.egg-info/PKG-INFO
writing dependency_links to jsbeautifier.egg-info/dependency_links.txt
writing entry points to jsbeautifier.egg-info/entry_points.txt
writing requirements to jsbeautifier.egg-info/requires.txt
writing top-level names to jsbeautifier.egg-info/top_level.txt
reading manifest file 'jsbeautifier.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching 'js-beautify'
writing manifest file 'jsbeautifier.egg-info/SOURCES.txt'
running build_ext
============================= test session starts ==============================
platform linux -- Python 3.6.8, pytest-4.2.1, py-1.7.0, pluggy-0.8.1
rootdir: /build/jsbeautifier-1.8.9, inifile:
collected 3 items

jsbeautifier/tests/test-packer.py E                                      [ 33%]
jsbeautifier/tests/testindentation.py ..                                 [100%]

==================================== ERRORS ====================================
__________________________ ERROR at setup of test_str __________________________
file /build/jsbeautifier-1.8.9/jsbeautifier/tests/test-packer.py, line 11
  def test_str(str, expected):
E       fixture 'str' not found
>       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, doctest_namespace, monkeypatch, pytestconfig, record_property, record_xml_attribute, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory
>       use 'pytest --fixtures [testpath]' for help on them.

/build/jsbeautifier-1.8.9/jsbeautifier/tests/test-packer.py:11
====================== 2 passed, 1 error in 0.06 seconds =======================
builder for '/nix/store/967sjl11npm9gnbcsd46i7drpbiy5r4d-jsbeautifier-1.8.9.drv' failed with exit code 1
e

Technical details

  • system: "x86_64-linux"
  • host os: Linux 4.19.25, NixOS, 18.09pre-git (Jellyfish)
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.1.3
  • channels(root): ""
  • channels(kalbasit): "home-manager-18.09, nixpkgs-18.09.932.09195057114"
  • channels(yl): ""
  • nixpkgs: /run/current-system/nixpkgs
@kalbasit kalbasit added this to the 19.03 milestone Mar 31, 2019
@kalbasit
Copy link
Member Author

/cc @apeyroux maintainer of this package.

@kalbasit
Copy link
Member Author

This was not happening back in dea01b8. I believe this started happening with version 1.8.0rc2 when test-packer was introduced upstream. beautifier/js-beautify@63013ff

@flokli
Copy link
Contributor

flokli commented Apr 7, 2019

fixed via #58632.

@flokli flokli closed this as completed Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants