Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grilo-plugins fails to build #59792

Closed
jtojnar opened this issue Apr 17, 2019 · 2 comments · Fixed by #59793
Closed

grilo-plugins fails to build #59792

jtojnar opened this issue Apr 17, 2019 · 2 comments · Fixed by #59793
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform

Comments

@jtojnar
Copy link
Contributor

jtojnar commented Apr 17, 2019

grilo-plugins fails to build due to missing libgdata headers.

Apparently this is a regression caused by c2de086

Interestingly,

libgdata_dep = dependency('libgdata', version: '>= 0.9.1', required: false)
libsoup_dep = dependency('libsoup-2.4', required: false)
warning('libsoup: @0@, libgdata @1@'.format(libsoup_dep.found(), libgdata_dep.found()))

prints WARNING: libsoup: false, libgdata true, even though libsoup is in Requires.

which is incongruous with the way pkg-config sees the package:

pkg-config --cflags libgdata
Package libsoup-2.4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `libsoup-2.4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libsoup-2.4', required by 'libgdata', not found

Originally posted by @jtojnar in #59765 (comment)
@jtojnar jtojnar added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Apr 17, 2019
jtojnar added a commit to jtojnar/nixpkgs that referenced this issue Apr 17, 2019
@jtojnar
gnome3.grilo-plugins: add dependencies
121dce6 
Add libsoup dependency which is required by libgdata dependency of YouTube plug-in
and also by Dleyna plug-in, and which was removed during previous clean-up.

Also add dependencies for lua-factory plug-in which is enabled by default by master.

Partially fixes: NixOS#59792
@jtojnar jtojnar mentioned this issue Apr 17, 2019
Merged
10 tasks
@jtojnar
Copy link
Contributor Author

jtojnar commented Apr 17, 2019 •
edited

We probably ought to propagate libsoup from libgdata, I only added it to buildInputs in #59793 since it is also a direct dependency of another plug-in.

Also this behaviour by meson is questionable.

cc @worldofpeace

@worldofpeace
Copy link
Contributor

Yeah, let's propagate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gnome3.grilo-plugins: add dependencies jtojnar/nixpkgs
2 participants
@jtojnar @worldofpeace