The "pfstools" package doesn't install the "pfsalign" program

[typedfern]

Issue description

The command-line tool "pfsalign", included in the pfstools package, uses computer vision (via OpenCV) to align images; with NixOS, however, it is not being built.

Steps to reproduce

Install pfstools.

Expected result:
The pfsalign command being available in bash.

Actual result:
No pfsalign command is installed.

Technical details

• system: "x86_64-linux"
• host os: Linux 4.14.90, NixOS, 18.09.1806.928ff62213b (Jellyfish)
• multi-user?: yes
• sandbox: yes
• version: nix-env (Nix) 2.1.3
• channels(cable): ""
• nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Solution

The Nix distribution of pfstools uses a different method to find the libexif library (which is needed to build pfsalign), but the part that builds pfsalign was not properly patched to use it. I got it to work with this patch:

diff -pruN a/src/camera/CMakeLists.txt b/src/camera/CMakeLists.txt
--- a/src/camera/CMakeLists.txt 2017-11-13 18:38:27.000000000 +0100
+++ b/src/camera/CMakeLists.txt 2018-12-30 14:55:30.235571520 +0100
@@ -9,7 +9,7 @@ target_link_libraries(${TRG} pfs)
 install (TARGETS ${TRG} DESTINATION bin)
 install (FILES ${TRG}.1 DESTINATION ${MAN_DIR})
 
-if( OpenCV_FOUND AND EXIF_FOUND )
+if( OpenCV_FOUND AND MYPKG_FOUND )
 
        set(TRG pfsalign)
        add_executable(${TRG} ${TRG}.cpp  "${GETOPT_OBJECT}")                  

[c0bw3b]

cc @juliendehos as maintainer