Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haskell library system-fileio tests fail #6144

Closed
tel opened this issue Feb 4, 2015 · 15 comments
Closed

Haskell library system-fileio tests fail #6144

tel opened this issue Feb 4, 2015 · 15 comments

Comments

@tel
Copy link
Contributor

tel commented Feb 4, 2015

Seems like a hardcoded path problem? The log is below.

Preprocessing test suite 'filesystem_tests' for system-fileio-0.3.16...
running tests
Running 1 test suites...
Test suite filesystem_tests: RUNNING...
[ ABORT ] posix.copyFile.iso8859
  Test aborted due to exception: /private/var/folders/lj/655x29_s66718hvw6bdcvy1w0000gn/T/nix-build-haskell-system-fileio-ghc7.8.4-0.3.16-shared.drv-0/tests.iso8859.48795/old_¡¢£.txt: openBinaryFile: does not exist (No such file or directory)

[ ABORT ] posix.withFile.read.iso8859
  Test aborted due to exception: /private/var/folders/lj/655x29_s66718hvw6bdcvy1w0000gn/T/nix-build-haskell-system-fileio-ghc7.8.4-0.3.16-shared.drv-0/tests.read.iso8859.48795/¡¢£.txt: openBinaryFile: does not exist (No such file or directory)

[ ABORT ] posix.withTextFile.iso8859
  Test aborted due to exception: /private/var/folders/lj/655x29_s66718hvw6bdcvy1w0000gn/T/nix-build-haskell-system-fileio-ghc7.8.4-0.3.16-shared.drv-0/tests.iso8859.48795/¡¢£.txt: openFile: does not exist (No such file or directory)

FAIL: 81 tests run, 66 tests passed, 12 tests skipped, 3 tests aborted
Test suite filesystem_tests: FAIL
Test suite logged to: dist/test/system-fileio-0.3.16-filesystem_tests.log
0 of 1 test suites (0 of 1 test cases) passed.

For now, I'm able to build with doCheck = false, though.

diff --git a/pkgs/development/libraries/haskell/system-fileio/default.nix b/pkgs/development/libraries/haskell/system-fileio/default.nix
index cf3dcee..5f5aa4c 100644
--- a/pkgs/development/libraries/haskell/system-fileio/default.nix
+++ b/pkgs/development/libraries/haskell/system-fileio/default.nix
@@ -17,4 +17,5 @@ cabal.mkDerivation (self: {
     license = self.stdenv.lib.licenses.mit;
     platforms = self.ghc.meta.platforms;
   };
+  doCheck = false;
 })
@peti
Copy link
Member

peti commented Feb 4, 2015

Have you reported this issue to the library authors?

@tel
Copy link
Contributor Author

tel commented Feb 4, 2015

I haven't. My nix-fu is weak, but it appears to be a nix packaging issue?

Or is the policy to try to convince library authors to ensure that all of their extra files are properly caught by cabal2nix?

A similar problem was occuring with shake a little while back, but I haven't tested it recently.

@peti
Copy link
Member

peti commented Feb 4, 2015

What makes you think that this might be a Nix packaging issue?

Note that cabal2nix doesn't package anything. We build the distribution tarballs from Hackage.

@tel
Copy link
Contributor Author

tel commented Feb 4, 2015

Because it appears to be failing to find a file ¡¢£.txt in the location the test expects it to be. I suppose I'm working on the assumption that this test passes if you were to just cabal get it. I can try to confirm that.

@peti
Copy link
Member

peti commented Feb 4, 2015

Again, we download release tarballs from Hackage, just like cabal get does. The environment this package builds in Nix is identical to that in which it builds on any other platform. There are no extra files, nor are there any files missing.

@peti
Copy link
Member

peti commented Feb 4, 2015

Also, note that the test suite succeeds just fine when run on our CI: http://hydra.nixos.org/job/nixpkgs/haskell-updates/haskellngPackages.system-fileio.x86_64-linux.

@tel
Copy link
Contributor Author

tel commented Feb 4, 2015

Interesting, I'll dig in more and open the issue for the library itself.

@peti
Copy link
Member

peti commented Feb 4, 2015

To me, it looks like the weird file name is causing trouble on your system, maybe because your file system or locale environment doesn't support it. I'm just guessing, though.

@peti
Copy link
Member

peti commented Feb 4, 2015

Tests succeed on Hydra; seems to be an issue with the machine running the build that ought to be fixed upstream.

@peti peti closed this as completed Feb 4, 2015
@tel
Copy link
Contributor Author

tel commented Feb 4, 2015

Yep—I agree. Closing here.

@tel
Copy link
Contributor Author

tel commented Feb 4, 2015

Thanks!

@jml
Copy link
Contributor

jml commented Feb 28, 2015

I ran into this issue. @tel did you discover what it was about your system that made it fail? Is there an upstream bug I can follow?

@jml
Copy link
Contributor

jml commented Feb 28, 2015

Never mind, found fpco/haskell-filesystem#5 which is the upstream bug.

@tel
Copy link
Contributor Author

tel commented Feb 28, 2015

Yeah, I've been just sitting on it since then. It seems like a Mac+Unicode kind of thing.

@peti
Copy link
Member

peti commented Mar 4, 2015

0af5205 re-enables the test suite on Darwin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants