ghcjs tests not running because the compiler version check is nonsensical

[nh2]

We noticed that ghcjs packages always run with --disable-tests.

This is most likely accidental, because we have in the generic Haskell builder:

nixpkgs/pkgs/development/haskell-modules/generic-builder.nix

Line 132 in 2dca1a6

(optionalString (isGhcjs || versionOlder "7" ghc.version) (enableFeature doCheck "tests"))

nixpkgs/pkgs/development/haskell-modules/generic-builder.nix

Line 16 in 2dca1a6

, doCheck ? !isCross && (stdenv.lib.versionOlder "7.4" ghc.version)

For ghcjs, ghc.version is 0.2.020170323.

So the tests don't run because 0.2.020170323 < 7.4.

The problem here is that ghcjs uses a different versioning scheme from ghc.

[nh2]

@peti Do you know why ghcjs has this 0.2.020170323 versioning scheme in nixpkgs?

At least the upstream Cabal package seems to follow the normal ghc versioning scheme:

https://github.com/ghcjs/ghcjs/blob/f4d35c734244b2a6f9048bbc8115f3008ec339e3/ghcjs.cabal#L2

Name:           ghcjs
Version:        8.6.0.1

[matthewbauer]

We should definitely make this more explicit but in my experience very few tests actually work in ghcjs. I think disabling them makes sense and is similar to how we disable test on cross compilation.

[peti]

@peti Do you know why ghcjs has this 0.2.020170323 versioning scheme in nixpkgs?

I have no idea. I am sorry, but I have never used nor packaged ghcjs.

[nh2]

@peti Ah, I thought you might know because of a1b6c5f, but I see that was just a revert.

Maybe @basvandijk knows from 1c656d2?

[stale]

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
2. Ask on the NixOS Discourse.
3. Ask on the #nixos channel on irc.freenode.net.