Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rspamd: disable LuaJIT support on aarch64 [ZHF 19.93] #68653

Merged
merged 1 commit into from
Sep 13, 2019

Conversation

WilliButz
Copy link
Member

Motivation for this change

#68361

Things done

When compiled with LuaJIT support, rspamd segfaults on aarch64.
Without LuaJIT, rspamd falls back to plain Lua and torch support needs to
be disabled.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS (x86_64-linux & aarch64-linux)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

When compiled with LuaJIT support, rspamd segfaults on aarch64.
Without LuaJIT, rspamd falls back to plain Lua and torch support needs to
be disabled.
@fpletz fpletz added this to the 19.09 milestone Sep 13, 2019
@fpletz fpletz merged commit 4fb48f9 into NixOS:master Sep 13, 2019
@avnik
Copy link
Contributor

avnik commented Sep 13, 2019

In theory luajit can be enabled for i686 as well, but I surprising, if someone use rspamd in production on i686

@WilliButz WilliButz deleted the rspamd/fix-aarch64-segfault branch September 13, 2019 12:35
@vcunat
Copy link
Member

vcunat commented Sep 15, 2019

Well, there are various workarounds to make LuaJIT work compatibly on aarch64, if you're really interested in that, but I believe there's apparently no standard/"clearly best" (in all cases) approach yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants