Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: useVaapi patch fails #73878

Closed
felschr opened this issue Nov 21, 2019 · 2 comments
Closed

chromium: useVaapi patch fails #73878

felschr opened this issue Nov 21, 2019 · 2 comments

Comments

@felschr
Copy link
Member

felschr commented Nov 21, 2019

Describe the bug
When I set useVaapi = true for chromium I get the following error on rebuild:

applying patch /nix/store/1spb17vn5gjwfr0izvhld1rimn1j8p30-chromium-vaapi.patch
patching file chrome/browser/about_flags.cc
Hunk #1 succeeded at 1738 with fuzz 1 (offset 24 lines).
Hunk #2 FAILED at 2345.
1 out of 2 hunks FAILED -- saving rejects to file chrome/browser/about_flags.cc.rej
patching file chrome/browser/flag_descriptions.cc
Hunk #1 succeeded at 3071 with fuzz 2 (offset -14 lines).
patching file chrome/browser/flag_descriptions.h
Hunk #1 FAILED at 1846.
1 out of 1 hunk FAILED -- saving rejects to file chrome/browser/flag_descriptions.h.rej
patching file gpu/config/software_rendering_list.json
Hunk #1 succeeded at 334 (offset -37 lines).
builder for '/nix/store/4brlz1jaw4ib45f25z3vwgi4f17mp85i-chromium-unwrapped-78.0.3904.97.drv' failed with exit code 1

Expected behavior
Rebuild should succeed.

Metadata

 - system: `"x86_64-linux"`
 - host os: `Linux 5.3.11, NixOS, 20.03pre202088.e89b21504f3 (Markhor)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.1`
 - channels(root): `"nixos-20.03pre202088.e89b21504f3, home-manager"`
 - channels(felschr): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute: chromium
@felschr felschr changed the title chromium: useVaapi patches fail chromium: useVaapi patch fails Nov 21, 2019
@veprbl
Copy link
Member

veprbl commented Nov 22, 2019

cc @colemickens @bendlas @ivan

bendlas added a commit that referenced this issue Nov 24, 2019
bendlas added a commit that referenced this issue Nov 24, 2019
#73878
(cherry picked from commit a52d767)
@bendlas
Copy link
Contributor

bendlas commented Nov 24, 2019

builds and runs for me, please test on vaapi-enabled machine

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this issue Jan 19, 2020
@felschr felschr closed this as completed Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants