-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lost git over ssh access to GitLab after update #74978
Comments
Try removing/commenting out the broken key and re-adding it from the interface, we had this broken state for a few keys too and that fixed it. It also is fixed on current nixpkgs branches |
@veprbl why that PR specifically? f3eb063 and a33ddd7 patched It's re-adding those keys via the web interface, or manually fixing in the file. We might want to document this in the 19.09 release notes, though. |
@globin I did that for all three keys. For two of them it helped, for the third one it didn't help. I just tried it once again and still this key is not working. Thanks anyway. |
I found that the key that was not working was present in |
I'm not sure if we can/should add code which tries to fixup halfway broken state - maybe it'd be a better idea to add some note to the changelog. @mawis, WDYT? |
@flokli I agree that somehow broken |
@mawis shouldn't this already be the case in pkgs/applications/version-management/gitlab/remove-hardcoded-locations.patch:160? (both on master and 19.09) |
@flokli Thanks for pointing this out. I must have missed, that this was fixed. Would have expected someone to have closed the ticket in that case already. I guess I should do so now :) |
Describe the bug
After doing a general update (
nixos-rebuild switch --upgrade
) and runningnix-collect-garbage -d
followed by a system reboot, I lost access to my GitLab repositories. I cannot tell which of the above steps exactly caused the problem to start, but it worked before and didn't after.At the beginning the problem I got was this:
I found the reason for this were entries in
/var/gitlab/state/home/.ssh/authorized_keys' where the following path was used for
ssh-agent`:(Note the path directily into the nix-store.)
After removing the key and re-adding it (using the GitLab web interface) I saw that the following path is used now:
But still it didn't work, just the error message changed:
Following to that I changed the path on the other keys as well. Interestingly on the other keys I now get access to the repository. So I have one GitLab account with three ssh keys added. One of the ssh-keys produces the "The project you were looking for could not be found." error message while the other two keys started to work again after I updated the path to gitlab-shell.
The content of
/var/gitlab/state/home/.ssh/authorized_keys
is:Only key-15 isn't working.
To Reproduce
Sorry, I don't know. Probably the way GitLab on NixOS handled this changed and an older version of GitLab has to be installed first to generate configuration, that contains paths into the nix store. Then it seems to fail after you upgrade and get a system where the nix store location of gitlab-agent changes.
Expected behavior
I would expect, that I continue to be able to access my git repositories over ssh after an update of GitLab and NixOS.
Metadata
"x86_64-linux"
Linux 4.19.87, NixOS, 19.09.1481.f3fa5a101eb (Loris)
yes
yes
nix-env (Nix) 2.3
/nix/var/nix/profiles/per-user/root/channels/nixos
Maintainer information:
The text was updated successfully, but these errors were encountered: