Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.tox is broken #76150

Closed
tbenst opened this issue Dec 21, 2019 · 4 comments
Closed

pythonPackages.tox is broken #76150

tbenst opened this issue Dec 21, 2019 · 4 comments
Labels
0.kind: bug 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python

Comments

@tbenst
Copy link
Contributor

tbenst commented Dec 21, 2019

Describe the bug
Broken by 5d95fcb (tested nix-build -I nixpkgs=. -A "python3Packages.tox" build before and after)

ERROR: Could not find a version that satisfies the requirement importlib-metadata<2,>=1.1.0; python_version < "3.8" (from tox==3.14.2) (from versions: none)
ERROR: No matching distribution found for importlib-metadata<2,>=1.1.0; python_version < "3.8" (from tox==3.14.2)

Maintainer information:
@FRidh @

flokli added a commit to flokli/nixpkgs that referenced this issue Dec 22, 2019
This unbreaks tox, closes NixOS#76150.

Turns out the importlib-metadata tests are fixed upstream too, so
re-enable them.
@prusnak
Copy link
Member

prusnak commented Dec 23, 2019

Will be fixed when #76059 is merged

@tobim
Copy link
Contributor

tobim commented Dec 28, 2019

For anyone that can't update their home-manager configuration because of this, you can temporarily add the following snippet into your ~/.config/nixpkgs/config.nix as a workaround:

{
  packageOverrides = pkgs: {
    python3 = pkgs.python3.override {
      packageOverrides = self: super:
      let
        importlib-metadata = super.importlib-metadata.overridePythonAttrs(old: rec {
          version = "1.3.0";
          src =  super.fetchPypi {
            pname = "importlib_metadata";
            inherit version;
            sha256 = "0ibvvqajphwdclbr236gikvyja0ynvqjlix38kvsabgrf0jqafh7";
          };
        });
      in {
        tox = super.tox.overridePythonAttrs(old: rec {
          catchConflicts = false;
          buildInputs = old.buildInputs ++ [ importlib-metadata ];
        });
      };
    };
  };
}

@stale
Copy link

stale bot commented Jun 25, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 25, 2020
@prusnak
Copy link
Member

prusnak commented Jun 25, 2020

This was fixed by #76059

@prusnak prusnak closed this as completed Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants