Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging JupyterWith in Nixpkgs #79703

Closed
guaraqe opened this issue Feb 10, 2020 · 4 comments
Closed

Merging JupyterWith in Nixpkgs #79703

guaraqe opened this issue Feb 10, 2020 · 4 comments
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python

Comments

@guaraqe
Copy link

guaraqe commented Feb 10, 2020

I am the maintainer of JupyterWith, a system for setting up JupyterLab severs in a deterministic way using Nix, and I would like to work on a PR to merge it in Nixpkgs. This would give access to many Jupyter kernels to standard Nix users. I have been tracking my progress inside the project in this issue: tweag/jupyenv#71

I am opening this issue in order to ask some questions:

  • I plan to do most of the work inside the current Jupyter folder. Is this the appropriate place for doing it?

  • It may happen that we need to override some global packages so that they work correctly with Jupyter. What is the correct way for doing that? As an user, I use overlays, but this doesn't seem to make sense inside Nixpkgs. Maybe standard overrides? Should these overridden packages available only locally or also globally?

  • I would like to add tests to every Jupyter kernel, which will involve running Jupyter on a sample Notebook. What would be the appropriate location for theses tests?

All feedback is welcome. As soon as I start the pull request, I will link it here.

@FRidh
Copy link
Member

FRidh commented Feb 10, 2020

  1. Yes, it's the correct folder. Do check what is there already, we should not be providing multiple implementations of the same or similar functionality. cc @aborsu
  2. This is tricky. I imagine you need to override the sub packages sets for which kernels exist. Those typically provide functionality for overriding.
  3. That could go in the jupyter folder, just make sure you use tiny notebooks (also no generated output).

@stale
Copy link

stale bot commented Aug 8, 2020

Hello, I'm a bot and I thank you in the name of the community for opening this issue.

To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it.

If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use Git blame or GitHub's web interface on the relevant files to find them.

Lastly, you can always ask for help at our Discourse Forum or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 8, 2020
@guaraqe
Copy link
Author

guaraqe commented Aug 10, 2020

Closing for the moment, will reopen if needed.

@guaraqe guaraqe closed this as completed Aug 10, 2020
@FRidh
Copy link
Member

FRidh commented Aug 10, 2020

Just want to point out the new Jupyter Hub service here #94783.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python
Projects
None yet
Development

No branches or pull requests

3 participants