-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doomseeker: fix build by using qt wrapper hook #79794
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhipple
commented
Feb 11, 2020
@GrahamcOfBorg build doomseeker |
This should be backported to both 19.09 and 20.03 please. |
Current master immediately crashes; this fixes the build and the program runs successfully. See NixOS#65399 for details. Closed NixOS#79128
bhipple
force-pushed
the
fix/doomseeker
branch
from
February 12, 2020 01:06
646e8c9
to
86ae622
Compare
@GrahamcOfBorg build doomseeker |
This avoids using NIX_CFLAGS_COMPILE by switching to hardeningDisable. The hack is also only needed for darwin sources and is not specific to clang. This also removes non-standard isClang argument.
@GrahamcOfBorg build doomseeker |
veprbl
approved these changes
Feb 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested to run on NixOS, tested to build with the clangStdenv
on NixOS.
veprbl
added
the
8.has: port to stable
A PR already has a backport to the stable release.
label
Feb 17, 2020
Thanks for backports @veprbl ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.has: port to stable
A PR already has a backport to the stable release.
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current master immediately crashes; this fixes the build and the program runs
successfully. See #65399 for details.
Closed #79128
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)