New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkgsMusl.libffi fails in test suite #79863
Comments
@nh2 seen this before by any chance? |
Note that |
|
Note that removing the |
Oof, that sounds rather nasty :( |
I compared two builds of When running without
When running with
Also when I compare the
--- /tmp/nix-build-expect-5.45.4.drv-0/expect5.45.4/configure 2020-02-12 14:58:13.913396295 +0000
+++ /tmp/nix-build-expect-5.45.4.drv-1/expect5.45.4/configure 2020-02-12 14:58:52.129964483 +0000
@@ -730,7 +730,6 @@
docdir
oldincludedir
includedir
-runstatedir
localstatedir
sharedstatedir
sysconfdir
@@ -811,7 +810,6 @@
sysconfdir='${prefix}/etc'
sharedstatedir='${prefix}/com'
localstatedir='${prefix}/var'
-runstatedir='${localstatedir}/run'
includedir='${prefix}/include'
oldincludedir='/usr/include'
docdir='${datarootdir}/doc/${PACKAGE_TARNAME}'
@@ -1064,15 +1062,6 @@
| -silent | --silent | --silen | --sile | --sil)
silent=yes ;;
- -runstatedir | --runstatedir | --runstatedi | --runstated \
- | --runstate | --runstat | --runsta | --runst | --runs \
- | --run | --ru | --r)
- ac_prev=runstatedir ;;
- -runstatedir=* | --runstatedir=* | --runstatedi=* | --runstated=* \
- | --runstate=* | --runstat=* | --runsta=* | --runst=* | --runs=* \
- | --run=* | --ru=* | --r=*)
- runstatedir=$ac_optarg ;;
-
-sbindir | --sbindir | --sbindi | --sbind | --sbin | --sbi | --sb)
ac_prev=sbindir ;;
-sbindir=* | --sbindir=* | --sbindi=* | --sbind=* | --sbin=* \
@@ -1210,7 +1199,7 @@
for ac_var in exec_prefix prefix bindir sbindir libexecdir datarootdir \
datadir sysconfdir sharedstatedir localstatedir includedir \
oldincludedir docdir infodir htmldir dvidir pdfdir psdir \
- libdir localedir mandir runstatedir
+ libdir localedir mandir
do
eval ac_val=\$$ac_var
# Remove trailing slashes.
@@ -1363,7 +1352,6 @@
--sysconfdir=DIR read-only single-machine data [PREFIX/etc]
--sharedstatedir=DIR modifiable architecture-independent data [PREFIX/com]
--localstatedir=DIR modifiable single-machine data [PREFIX/var]
- --runstatedir=DIR modifiable per-process data [LOCALSTATEDIR/run]
--libdir=DIR object code libraries [EPREFIX/lib]
--includedir=DIR C header files [PREFIX/include]
--oldincludedir=DIR C header files for non-gcc [/usr/include]
@@ -8639,10 +8627,10 @@
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking stty to use" >&5
$as_echo_n "checking stty to use... " >&6; }
-if test -r /usr/local/nix/store/ignm17b032p59sfx1mbixn4kfl7g5aa3-coreutils-8.31/bin/stty ; then
- STTY_BIN=/usr/local/nix/store/ignm17b032p59sfx1mbixn4kfl7g5aa3-coreutils-8.31/bin/stty
+if test -r /usr/local/bin/stty ; then
+ STTY_BIN=/usr/local/bin/stty
else
- STTY_BIN=/nix/store/ignm17b032p59sfx1mbixn4kfl7g5aa3-coreutils-8.31/bin/stty
+ STTY_BIN=/bin/stty
fi
{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $STTY_BIN" >&5
$as_echo "$STTY_BIN" >&6; } Why would |
No idea tbh.... But the build was pretty weird before - I still don't exactly know why the addition was needed. Does |
I'll make a PR out of dfinity-lab@a4e23f3 and ask ofborg to build |
This upgrades `nixpkgs` to DFINITY's fork of nixpkgs which tracks the `master` branch. There're only two patches on top of `master`: ``` commit a4e23f32f8d7006e217125a9123b53597b9c0c24 (HEAD -> dfinity-motoko, dfinity-lab/dfinity-motoko) Author: Bas van Dijk <v.dijk.bas@gmail.com> Date: Wed Feb 12 16:08:05 2020 +0100 expect: remove autoreconfHook since that causes a wrong path to stty See: NixOS/nixpkgs#79863 commit f359aea057db81c51e55d7250283a0b2201bd6b6 Author: Bas van Dijk <v.dijk.bas@gmail.com> Date: Thu Feb 6 19:14:09 2020 +0100 libuv: 1.34.1 -> 1.34.2 (cherry picked from commit 21ad5c123b8e76ab241b89acbc8db24925244d63) ``` We need this patch in order to build `motoko` without using the upstream `cache.nixos.org`. It would be good not to use an external cache to decrease the chance an attacker can infect the cache with a trojan and to ensure DFINITY can always build their own code without depending on an external cache.
This upgrades `nixpkgs` to DFINITY's fork of nixpkgs which tracks the `master` branch. There're only two patches on top of `master`: ``` commit a4e23f32f8d7006e217125a9123b53597b9c0c24 (HEAD -> dfinity-motoko, dfinity-lab/dfinity-motoko) Author: Bas van Dijk <v.dijk.bas@gmail.com> Date: Wed Feb 12 16:08:05 2020 +0100 expect: remove autoreconfHook since that causes a wrong path to stty See: NixOS/nixpkgs#79863 commit f359aea057db81c51e55d7250283a0b2201bd6b6 Author: Bas van Dijk <v.dijk.bas@gmail.com> Date: Thu Feb 6 19:14:09 2020 +0100 libuv: 1.34.1 -> 1.34.2 (cherry picked from commit 21ad5c123b8e76ab241b89acbc8db24925244d63) ``` We need this patch in order to build `motoko` without using the upstream `cache.nixos.org`. It would be good not to use an external cache to decrease the chance an attacker can infect the cache with a trojan and to ensure DFINITY can always build their own code without depending on an external cache.
This upgrades `nixpkgs` to DFINITY's fork of nixpkgs which tracks the `master` branch. There're only two patches on top of `master`: ``` commit a4e23f32f8d7006e217125a9123b53597b9c0c24 (HEAD -> dfinity-motoko, dfinity-lab/dfinity-motoko) Author: Bas van Dijk <v.dijk.bas@gmail.com> Date: Wed Feb 12 16:08:05 2020 +0100 expect: remove autoreconfHook since that causes a wrong path to stty See: NixOS/nixpkgs#79863 commit f359aea057db81c51e55d7250283a0b2201bd6b6 Author: Bas van Dijk <v.dijk.bas@gmail.com> Date: Thu Feb 6 19:14:09 2020 +0100 libuv: 1.34.1 -> 1.34.2 (cherry picked from commit 21ad5c123b8e76ab241b89acbc8db24925244d63) ``` We need this patch in order to build `motoko` without using the upstream `cache.nixos.org`. It would be good not to use an external cache to decrease the chance an attacker can infect the cache with a trojan and to ensure DFINITY can always build their own code without depending on an external cache.
Indeed, my CI noticed this failure, the first failing build is https://buildkite.com/nh2/static-haskell-nix/builds/287#52588b27-84ce-4cd7-97ee-4496fcaa2e37 |
I'm building static-haskell-nix on top of your patch here: https://buildkite.com/nh2/static-haskell-nix/builds/291#8eed5f13-bcf1-48c8-b084-600150bad27b Also noticed that another thing broke though:
|
My bad, I ran the wrong commit. This is the real build: https://buildkite.com/nh2/static-haskell-nix/builds/294 #80006 does seem to fix the problem; my |
Fixes: NixOS#79863 (cherry picked from commit b30dc0f)
Fixes: NixOS#79863 (cherry picked from commit b30dc0f)
Describe the bug
On the latest
nixpkgs
master
(8cc8b3b):Metadata
Maintainer information:
The text was updated successfully, but these errors were encountered: