-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iterm2: 3.0.14 -> 3.3.9 & fix build #81443
Conversation
Just tested on macOS 10.15 and it works! I left two questions in the review, however:
These may help me fix other macOS derivations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, alltho I'm not sure if it's really worth maintaining impure packages in nixpkgs.
@LnL7 Yeah I agree. I first tried to build it using the As it is a pretty popular app on MacOS I still fixed it while at it. |
Creating pure derivations using sandboxing is definitely difficult for apps relying on Xcode but the main issue with Catalina was that:
See the mentioned pull request here on how you can solve that issue using the |
Aha! Nice. Thanks for the explanations and the link to your other PR, @tricktron. |
Motivation for this change
Fixes #80647 and builds iterm2 impurely. See this pull request for the reasons.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)