-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snippetpixie: 1.2.2 -> 1.3.1 #81554
snippetpixie: 1.2.2 -> 1.3.1 #81554
Conversation
This is more for general nix code, the style the package had before was formatting specific for expressions in nixpkgs https://github.com/nix-community/nixpkgs-fmt. I'd prefer if you reverted it. |
4339990
to
017926a
Compare
Sorry about that, did not know there are two styles in play. I've completely reverted formatting changes and ran |
Uhnn, we don't have anything really official for this yet... So you can imagine some sort of impending code style battle 🤣 (hopefully not) |
It seems you using wnck makes this not work with wayland. Guess that's reworking to do in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yeah, it's a pain, needed more robust window activation notifications to be able to implement the new trigger key checking for apps that aren't very accessibility savvy, hope to find a better solution in the future. Thanks for the PR review @worldofpeace, much appreciated. |
Motivation for this change
Updated to latest version.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)