Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binutils: add amd64 as additional target when on i686-linux #857

Closed
wants to merge 1 commit into from
Closed

binutils: add amd64 as additional target when on i686-linux #857

wants to merge 1 commit into from

Conversation

errge
Copy link
Contributor

@errge errge commented Aug 22, 2013

This is very convenient when working on an i686 installation with an amd64 kernel. I usually do this to make everything small and fast (i686), but occasionally I can still compile stuff to amd64 if the extra registers are needed. It'd be convenient to use the same binutils tools for those binaries in this case. This is already like this in Debian, so I don't think we will meet any issues.

Plese note that this may trigger an stdenv rebuild, so you may want to merge it to some other branch than master.

@errge
Copy link
Contributor Author

errge commented Aug 27, 2013

ping

@vcunat
Copy link
Member

vcunat commented Aug 27, 2013

Ah, well, this is a stdenv change, so it belongs to stdenv-updates instead of master. Currently it seems it won't take too long to stabilize stdenv-updates.

I see no reason against this. It's seems useless but harmless for people with 32-bit kernel.

@vcunat
Copy link
Member

vcunat commented Aug 27, 2013

If there's no reaction within a few days, I'll cherry-pick this into stdenv-updates.

@errge
Copy link
Contributor Author

errge commented Aug 31, 2013

Yes, it's an stdenv-updates, you're right, please cherry pick it to the stdenv-updates branch.

@vcunat
Copy link
Member

vcunat commented Sep 2, 2013

ATM I'm verifying things still build, to be sure. I'll push after that.

vcunat added a commit that referenced this pull request Sep 2, 2013
Also some style refactoring around repeating "stdenv.lib.optional*".
The author of the idea is @errge.
@vcunat
Copy link
Member

vcunat commented Sep 4, 2013

Oh, I forgot to close this (github only does this automatically after including to master, which doesn't seem appropriate for our workflow).

Thanks.

@vcunat vcunat closed this Sep 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants