-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/modules/security/acme: unnecessary lego run when lego renew fails #86184
Comments
Can probably fix this by checking for the existence of the cert file. Will add it to the big list of changes needed for the rewrite. |
I have found another scenario to reproduce this problem. On my server, I am setting the networking configuration statically which leads to the So in my case, at every boot, I have a ACME service that starts before the network is operational. That translates into:
So at every boot, the
… and then the
Needless to say, I reach the Duplicate Certificate limit of 5 per week very quickly. |
That would sure help.
|
Related issues in Lego to combine |
Describe the bug
A timeout when running
lego renew
automatically triggers alego run
.First, it is not necessary in the case there already exists a valid certificate but worse, it is even detrimental because it leads to generate a brand new certificate which brings the number of generations closer to the Duplicate Certificate limit of 5 per week.
Here is the timeout I am talking about:
net/http: TLS handshake timeout
To Reproduce
N/A
Expected behavior
A timeout when
lego renew
runs should not lead tolego run
.Notify maintainers
@abbradar @fpletz @globin @m1cr0man
Metadata
Please run
nix-shell -p nix-info --run "nix-info -m"
and paste the result.Maintainer information:
The text was updated successfully, but these errors were encountered: