-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popcorn time changed their package format / download source #8800
Comments
Hey thanks for the initial work! They seem to have combined the nw binary and package.nw already into the Popcorn-Time binary. The default nw binary does not work on NixOS, so that's why it fails to run :'(. Splitting the Another possiblity is using the source-based variant of this package (https://github.com/bobvanderlinden/nixpkgs/tree/popcorntime-source) and use that to create package.nw. |
Hum the source based approach make sense. Is it working ? Is there a way to build ffmpedsumo? Look like chromium could also benefit from it: https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/networking/browsers/chromium/browser.nix#L16 |
I updated your branch to 0.8.3-0: MasseGuillaume@fdbf4c9 Two main issues video js: No compatible source was found for this video
The TV series tab does not work anymore (probably a bug in their code):
|
In general, I'd vote for a source-based package, as 99% of nixpkgs works that way and it has a few benefits. |
@copumpkin This package is a bit trickier. It relies on npm, grunt and bower. These steps mostly download and bundles HTML/JS/CSS source code. The NixOS package just took the packaged HTML/JS/CSS and combines it with the @MasseGuillaume I'll give your version of the source package a try. |
FYI: If your binary for nw.js is not one of version 0.12.1, then the application will not work properly. If the binary does not contain the right codecs, then playback of videos will fail. And a fast search tells me that that NixOS uses nw.js 9 or 11. |
@sv244 oh thanks. totally make sense! what about the TV series tab? I did deleted the |
I had the same problems @MasseGuillaume mentioned. Also when I deleted ~/.config/Popcorn-Time, which also had no effect. |
@bobvanderlinden I was trying that right now :P. Do you know how to find missing files. node-webkit is a big black box to me and having error messages like:
does not really help. |
@MasseGuillaume I ran into the same problem. It's because nwjs_12 doesn't have Edit: I get this as the error when running popcorntime:
|
great. I think |
Good one. It seems to be loading |
The SUID error: nwjs/nw.js#2699 |
@sv244 Thanks, that saved me of unnecessary searching. Running nwjs without popcorntime works correctly, but it does still it'll result in:
So, both of these can be ignored. The problem is with:
|
Ok, it was indeed missing libudev. I found a workaround that was used in Spotify's package and used a similar approach: bobvanderlinden@2df5322 It now seems to be working, video as well as the tv shows tab! |
haha omg I'm looking at this file right now ;-) |
@bobvanderlinden good news. testing now |
@bobvanderlinden outch the sound does not work. |
Hmm, it did here. What output do you get? |
@bobvanderlinden does work in the trailer & movie. didn't work in TV series |
Aah, hmm, you're right. It doesn't work here either. Do tv-shows use a different codec or need a different libffmpegsumo.so? The only error I see when playing is:
But it seems to me that's unrelated. @sv244 Could you shed some light on this? |
It does work for some series |
Hmm, ok. Since we're using Popcorntime's libffmpegsumo.so, I'd guess it does the same on Ubuntu/Debian. Just a guess, but I haven't tried this (no Ubuntu/Debian here). |
It's not that bad I think I only saw old episode of Homeland not working. |
I think you should send a PR and we can get it better from here. Currently we have a broken package :-S in master. |
@MasseGuillaume indeed, I was also watching an old episode (never used popcorntime for tv-shows). Newer episodes do seem to work here too. I've cleaned up the commits and did a PR: #8819 |
It depends on the audio codec. Not sure really. If its our libffmpegsumo.so then it should work. What episode exactly? |
@sv244 Homeland Season 1 for example. |
@sv244 The walking dead season 1 episode 1 |
The Walking Dead S01E01 720p gives me (OS X 10.10, so not real Linux ^^) I don't have a 'Homeland Season 1' at the moment.. |
@sv244 ok, as long as it's not a packaging problem it's alright. |
Ops I meant Homeland S02. |
Closing. If you're having trouble violating copyright, that's not an issue for the NixOS project, IMO. |
Hey @bobvanderlinden,
I cannot get the new package format to work. This is what I have so far: https://github.com/MasseGuillaume/nixpkgs/blob/a2505fcac96681d118dd561f1652a340d101b6c7/pkgs/applications/video/popcorntime/default.nix#L26
package content:
The text was updated successfully, but these errors were encountered: