Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

veriT: 201410 -> 201506 #9451

Merged
merged 1 commit into from
Aug 26, 2015
Merged

veriT: 201410 -> 201506 #9451

merged 1 commit into from
Aug 26, 2015

Conversation

gebner
Copy link
Member

@gebner gebner commented Aug 26, 2015

No description provided.


enableParallelBuilding = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep this line please? If it was there it was to point parallel building is not suitable for this package. Removing it makes people think it could be enabled.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was the one who added the line in the first place. Since then, upstream has switched to a new autotools-based build system which seems to work just fine with parallel builds (I ran nix-build --check a few times and it didn't complain).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parallel builds are disabled by default, you have to enableParallelBuilding = true.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being unclear; I locally added enableParallelBuilding = true to the derivation, built it several times with nix-build --check and verified with top that is indeed being built in parallel.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so you didn't enable it in this PR.

lucabrunox pushed a commit that referenced this pull request Aug 26, 2015
@lucabrunox lucabrunox merged commit 6979c1b into NixOS:master Aug 26, 2015
@lucabrunox
Copy link
Contributor

Built locally thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants