FaustLive does not compile

[suhr]

Describe the bug

faustlive> ../../src/Network/FLServerHttp.cpp: In member function 'bool FLServerHttp::start()':
faustlive> ../../src/Network/FLServerHttp.cpp:78:32: error: invalid conversion from 'int (*)(void*, MHD_Connection*, const char*, const char*, const char*, const char*, size_t*, void**)' {aka 'int (*)(void*, MHD_Connection*, const char*, const char*, const char*, const char*, long unsigned int*, void**)'} to 'MHD_AccessHandlerCallback' {aka 'MHD_Result (*)(void*, MHD_Connection*, const char*, const char*, const char*, const char*, long unsigned int*, void**)'} [-fpermissive]
faustlive> 78 |                                &answerToConnection,
faustlive> |                                ^~~~~~~~~~~~~~~~~~~
faustlive> |                                |
faustlive> |                                int (*)(void*, MHD_Connection*, const char*, const char*, const char*, const char*, size_t*, void**) {aka int (*)(void*, MHD_Connection*, const char*, const char*, const char*, const char*, long unsigned int*, void**)}
faustlive> In file included from ../../src/Network/FLServerHttp.h:40,
faustlive> from ../../src/Network/FLServerHttp.cpp:22:
faustlive> /nix/store/xfjjhyxbrv9zylph4l6l7hpj4pys66k5-libmicrohttpd-0.9.71-dev/include/microhttpd.h:2428:45: note:   initializing argument 5 of 'MHD_Daemon* MHD_start_daemon(unsigned int, uint16_t, MHD_AcceptPolicyCallback, void*, MHD_AccessHandlerCallback, void*, ...)'
faustlive> 2428 |                   MHD_AccessHandlerCallback dh, void *dh_cls,
faustlive> |                   ~~~~~~~~~~~~~~~~~~~~~~~~~~^~
faustlive> ../../src/Network/FLServerHttp.cpp: In static member function 'static int FLServerHttp::answerToConnection(void*, MHD_Connection*, const char*, const char*, const char*, const char*, size_t*, void**)':
faustlive> ../../src/Network/FLServerHttp.cpp:214:121: error: invalid conversion from 'int (*)(void*, MHD_ValueKind, const char*, const char*, const char*, const char*, const char*, uint64_t, size_t)' {aka 'int (*)(void*, MHD_ValueKind, const char*, const char*, const char*, const char*, const char*, long unsigned int, long unsigned int)'} to 'MHD_PostDataIterator' {aka 'MHD_Result (*)(void*, MHD_ValueKind, const char*, const char*, const char*, const char*, const char*, long unsigned int, long unsigned int)'} [-fpermissive]
faustlive> 214 |             con_info->postprocessor = MHD_create_post_processor(connection, POSTBUFFERSIZE, iteratePost, (void*)con_info);
faustlive> |                                                                                                                         ^
faustlive> |                                                                                                                         |
faustlive> |                                                                                                                         int (*)(void*, MHD_ValueKind, const char*, const char*, const char*, const char*, const char*, uint64_t, size_t) {aka int (*)(void*, MHD_ValueKind, const char*, const char*, const char*, const char*, const char*, long unsigned int, long unsigned int)}
faustlive> In file included from ../../src/Network/FLServerHttp.h:40,
faustlive> from ../../src/Network/FLServerHttp.cpp:22:
faustlive> /nix/store/xfjjhyxbrv9zylph4l6l7hpj4pys66k5-libmicrohttpd-0.9.71-dev/include/microhttpd.h:3465:49: note:   initializing argument 3 of 'MHD_PostProcessor* MHD_create_post_processor(MHD_Connection*, size_t, MHD_PostDataIterator, void*)'
faustlive> 3465 |                            MHD_PostDataIterator iter, void *iter_cls);
faustlive> |                            ~~~~~~~~~~~~~~~~~~~~~^~~~
faustlive> make[2]: *** [Makefile:497: tmp/FLServerHttp.o] Error 1
faustlive> make[2]: *** Waiting for unfinished jobs....
faustlive> make[2]: Leaving directory '/build/source/Build/fldir'
faustlive> make[1]: *** [Makefile:37: unix] Error 2
faustlive> make[1]: Leaving directory '/build/source/Build'
faustlive> make: *** [Makefile:30: all] Error 2

To Reproduce

1. nix profile install self#faustlive -L

Notify maintainers

@NegaNexus @magnetophon

[magnetophon]

I was informed on slack that the dev branch has a commit that fixes this problem.

[suhr]

This is the fix, I guess: grame-cncm/faustlive@c16565d#diff-5abd81d274b8e78c9c2fcc2821f7a867R78

Can we add it to the derivative as a patch?

[magnetophon]

I tested the latest commit on the dev branch, and that builds and runs.
Shall I do a PR?

@suhr I guess a patch might work as well, but what would be the advantages of going that route?
I can see not wanting to use a dev version of important libs and programs, but imho it's fine in this case.

[suhr]

Shall I do a PR?

Sure.