Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.cocotb: fix tests, 1.3.1 -> 1.3.2 #100272

Merged
merged 2 commits into from Oct 12, 2020

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Oct 11, 2020

Motivation for this change

ZHF: #97479

A bump to our icarus verilog (just "verilog" for some reason) broke an expected-failure test because of a fix contained in it. Disable those tests (using an ugly hack). Reported @ cocotb/cocotb#2121.

While we're at it, bump to 1.3.2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
risicle added 2 commits Oct 11, 2020
Copy link
Contributor

@drewrisinger drewrisinger left a comment

  • Diff LGTM. Nitpicks: could move comments out of checkPhase, and this actually applies to both python27 & python3 (commit/title says py3)
  • Commits LGTM
  • Builds via nix-review on linux 86_64:
https://github.com/NixOS/nixpkgs/pull/100272
3 packages built:
python27Packages.cocotb python37Packages.cocotb python38Packages.cocotb

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 100272 1

3 packages built:
  • python27Packages.cocotb
  • python37Packages.cocotb
  • python38Packages.cocotb

@jonringer jonringer merged commit 0b5d5d6 into NixOS:master Oct 12, 2020
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants