New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tdesktop: 2.3.0 -> 2.4.3 and enable webrtc #100450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calls work with and w/o video as intended
pkgs/applications/networking/instant-messengers/telegram/tdesktop/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/instant-messengers/telegram/tdesktop/tg_owt.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/instant-messengers/telegram/tdesktop/tg_owt.nix
Outdated
Show resolved
Hide resolved
Now I patched cmake files to fix include directories (with install interface) and correctly install headers. There's still a small issue that we need to nuke reference to include directory of |
pkgs/applications/networking/instant-messengers/telegram/tdesktop/tg_owt.nix
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this clearly isn't ideal but given the circumstances I think that it's pretty good. I briefly tested tdesktop
and everything seems fine (I didn't test calls though... But that part should already be covered anyway).
Would be nice if we could upstream/drop our patch in the future though.
@oxalica huge thanks for this!
Might be fixed by 2.4.4 (https://github.com/telegramdesktop/tdesktop/releases/tag/v2.4.4: "Several crash fixes.", 253c9cb). I only tested it for <5 minutes though. Anyway, if that doesn't fix it this should go into a new issue with additional information. |
More information like nixpkgs git revision and stderr output? |
@volth Does 2.4.7 work for you? |
Enables WebRTC by packaging tg_owt. (cherry picked from commit 4c59c0b)
Motivation for this change
Bump version.
According to telegramdesktop/tdesktop#8483 (comment), webrtc is now a require dependency, and a special fork tg_owt is used.
So this PR also packaged
tg_owt
and enabled webrtc.Fix #98994. Video calls work for me
but there's no sound. Audio also works.@mkg20001 for more test.
There's another attempt #100062 to package (official?)
libwebrtc
. It is how Arch package tdesktop but seems to be quite complicated, and it also need to patch tdesktop.Well, I think the
tg_owt
fork may be more suitable here like we already use bundledrlottie
andlibtgvoip
, but we can also change it later whenlibwebrtc
is in nixpkgs.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)cc @primeos @abbradar