Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfs-replicate: 1.1.14 -> 1.2.0 #100811

Closed
wants to merge 1 commit into from
Closed

Conversation

@alunduil
Copy link
Contributor

@alunduil alunduil commented Oct 17, 2020

This fixes the build failures when switching to NixOS 20.09 and needs to
be merged into that branch as well. Let me know if that's another pull
request I need to submit.

I've verified this functions with: nix-build . -A pkgs.zfs-replicate
and I no longer get the errors I was getting when switching to 20.09
without this version change.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@alunduil
Copy link
Contributor Author

@alunduil alunduil commented Oct 17, 2020

I'm not sure why the binary isn't finding the python modules any longer and when running result/bin/zfs-replicate I get an ModuleNotFoundError on the package itself. Any assistance would be appreciated as Python isn't something I'm super familiar with any more.

This fixes the build failures when switching to NixOS 20.09 and needs to
be merged into that branch as well.  Let me know if that's another pull
request I need to submit.

I've verified this functions with: `nix-build . -A pkgs.zfs-replicate`
and I no longer get the errors I was getting when switching to 20.09
without this version change.
@alunduil alunduil force-pushed the update-zfs-replicate branch from 972abee to dc15676 Oct 17, 2020
@alunduil
Copy link
Contributor Author

@alunduil alunduil commented Oct 17, 2020

Alright, I got it figured out (problems with setup.cfg and namespace packages). Everything should be good to go now. I'll ensure the fixes are landed on the zfs-replicate side as well.

@alunduil
Copy link
Contributor Author

@alunduil alunduil commented Oct 25, 2020

This is identical to the referenced commit but must still be ported to stable. How do we go about that? Do I need to mark the other pull request as this one has been?

@roberth
Copy link
Member

@roberth roberth commented Nov 6, 2020

#101970 was merged in place of this PR. Thanks @alunduil!

@roberth roberth closed this Nov 6, 2020
@alunduil alunduil deleted the update-zfs-replicate branch Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants