Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netevent: init at 20201018 #101019

Merged
merged 2 commits into from Dec 7, 2020
Merged

netevent: init at 20201018 #101019

merged 2 commits into from Dec 7, 2020

Conversation

rgrunbla
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@RaitoBezarius
Copy link
Member

Result of nixpkgs-review pr 101019 1

1 package built:
  • netevent

@RaitoBezarius
Copy link
Member

Result of nixpkgs-review pr 101019 1

1 package built:
  • netevent

catern
catern suggested changes Oct 18, 2020
View reviewed changes
Copy link
Contributor

@catern catern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message/PR title should be netevent: init at 20201018

pkgs/tools/inputmethods/netevent/default.nix Show resolved Hide resolved
pkgs/tools/inputmethods/netevent/default.nix Outdated Show resolved Hide resolved
pkgs/tools/inputmethods/netevent/default.nix Outdated Show resolved Hide resolved
pkgs/tools/inputmethods/netevent/default.nix Show resolved Hide resolved
pkgs/tools/inputmethods/netevent/default.nix Outdated Show resolved Hide resolved
@rgrunbla rgrunbla changed the title init: netevent at 20201018 netevent: init at 20201018 Oct 19, 2020
SuperSandro2000
SuperSandro2000 requested changes Nov 27, 2020
View reviewed changes
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/tools/inputmethods/netevent/default.nix Outdated Show resolved Hide resolved
pkgs/tools/inputmethods/netevent/default.nix Outdated Show resolved Hide resolved
pkgs/tools/inputmethods/netevent/default.nix Outdated Show resolved Hide resolved
pkgs/tools/inputmethods/netevent/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101019 run on x86_64-linux 1

1 package built:
  • netevent

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101019 run on x86_64-linux 1

1 package built:
  • netevent

@SuperSandro2000 SuperSandro2000 merged commit a174e4d into NixOS:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catern catern catern requested changes

@RaitoBezarius RaitoBezarius RaitoBezarius approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rgrunbla @RaitoBezarius @SuperSandro2000 @catern