Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] backport yed updates #101239

Merged

Conversation

@matthiasbeyer
Copy link
Contributor

@matthiasbeyer matthiasbeyer commented Oct 21, 2020

Motivation for this change

yed does not build on 20.03 due to


builder for '/nix/store/ysgcm7y0m861bk6ncpb1rvp7jmvl848j-source.drv' failed with exit code 1; last 10 log lines:
  100 29261  100 29261    0     0   111k      0 --:--:-- --:--:-- --:--:--  111k
  unpacking source archive /build/yEd-3.19.1.1.zip
  [/build/yEd-3.19.1.1.zip]
    End-of-central-directory signature not found.  Either this file is not
    a zipfile, or it constitutes one disk of a multi-part archive.  In the
    latter case the central directory and zipfile comment will be found on
    the last disk(s) of this archive.
  unzip:  cannot find zipfile directory in one of /build/yEd-3.19.1.1.zip or
          /build/yEd-3.19.1.1.zip.zip, and cannot find /build/yEd-3.19.1.1.zip.ZIP, period.
  do not know how to unpack source archive /build/yEd-3.19.1.1.zip
cannot build derivation '/nix/store/g0j9kvrq06jaqy6vbqij7jackvdqij5s-yEd-3.19.1.1.drv': 1 dependencies couldn't be built

And I hope this fixes the issue.

Things done

git cherry-pick -x -s ...


@abbradar (pkg maintainer)

r-ryantm and others added 2 commits Oct 21, 2020
(cherry picked from commit 0e0995d)
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit d3a2be1)
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@ofborg ofborg bot requested a review from abbradar Oct 21, 2020
@worldofpeace worldofpeace changed the base branch from nixos-20.03 to release-20.03 Oct 31, 2020
Copy link
Contributor

@worldofpeace worldofpeace left a comment

lgtm, builds locally

@worldofpeace worldofpeace merged commit 5c52210 into NixOS:release-20.03 Oct 31, 2020
17 of 18 checks passed
17 of 18 checks passed
@ofborg[bot]
yed, yed.passthru.tests on x86_64-darwin
Details
@ofborg[bot]
yed, yed.passthru.tests on aarch64-linux No attempt
Details
@ofborg[bot]
yed, yed.passthru.tests on x86_64-linux No attempt
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="680cf57"; rev="680cf57169ce91a133bae49225375e65d25c7d14"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="680cf57"; rev="680cf57169ce91a133bae49225375e65d25c7d14"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="680cf57"; rev="680cf57169ce91a133bae49225375e65d25c7d14"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="680cf57"; rev="680cf57169ce91a133bae49225375e65d25c7d14"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="680cf57"; rev="680cf57169ce91a133bae49225375e65d25c7d14"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="680cf57"; rev="680cf57169ce91a133bae49225375e65d25c7d14"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="680cf57"; rev="680cf57169ce91a133bae49225375e65d25c7d14"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@matthiasbeyer matthiasbeyer deleted the nixos-20.03-backport-yed branch Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants