Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

surf: 2.0 -> unstable-2019-02-08 #101430

Merged
merged 1 commit into from Nov 26, 2020
Merged

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 23, 2020

Motivation for this change

Closes #81629

@alexherbo2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@alexherbo2
Copy link
Contributor

@alexherbo2 alexherbo2 commented Oct 23, 2020

@SuperSandro2000 Can you update the description to replace Surfsurf and WebKit/GTKWebKitGTK?

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Oct 23, 2020

@SuperSandro2000 Can you update the description to replace Surfsurf and WebKit/GTKWebKitGTK?

Changed that.

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Oct 23, 2020

Result of nixpkgs-review pr 101430 1

2 packages built:
  • surf (surf-webkit2)
  • surf-display

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Nov 26, 2020

Result of nixpkgs-review pr 101430 run on x86_64-linux 1

2 packages built:
  • surf (surf-webkit2)
  • surf-display

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Nov 26, 2020

Result of nixpkgs-review pr 101430 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • surf

@SuperSandro2000 SuperSandro2000 merged commit 1180d54 into NixOS:master Nov 26, 2020
19 checks passed
19 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="80c78cc"; rev="80c78cc2e4f3e5441aca64184c64e4083bde0df0"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="80c78cc"; rev="80c78cc2e4f3e5441aca64184c64e4083bde0df0"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="80c78cc"; rev="80c78cc2e4f3e5441aca64184c64e4083bde0df0"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="80c78cc"; rev="80c78cc2e4f3e5441aca64184c64e4083bde0df0"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="80c78cc"; rev="80c78cc2e4f3e5441aca64184c64e4083bde0df0"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="80c78cc"; rev="80c78cc2e4f3e5441aca64184c64e4083bde0df0"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="80c78cc"; rev="80c78cc2e4f3e5441aca64184c64e4083bde0df0"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
surf, surf.passthru.tests on aarch64-linux Success
Details
@ofborg[bot]
surf, surf.passthru.tests on x86_64-linux Success
Details
@SuperSandro2000 SuperSandro2000 deleted the 81629-surf branch Nov 26, 2020
@SuperSandro2000 SuperSandro2000 changed the title surf: 2.0 -> 2019-02-08-unstable surf: 2.0 -> unstable-2019-02-08 Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants