Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk3: Use tracker3 for search #101537

Merged
merged 4 commits into from Nov 28, 2020
Merged

gtk3: Use tracker3 for search #101537

merged 4 commits into from Nov 28, 2020

Conversation

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 24, 2020

Upstream recommends to build GTK 3 with Tracker 3 enabled. Without it, according to my tests, the search only affects the current directory.

But previously tracker depended on gtk3 through libsoupsysprofgtk3, which only got resolved in #101528, and, what is more, even now through wrapGAppsHook. To resolve this, I created wrapGAppsNoGuiHook, which does not propagate dependencies needed for graphical programs. I tried to document it, when I noticed GdkPixbuf loaders are not mentioned so I added a docs section before I forget.

This is yet untested, will need to check what happens when user tries to search in GTK file dialogue on systems without Tracker D-Bus service.

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 24, 2020

This is yet untested, will need to check what happens when user tries to search in GTK file dialogue on systems without Tracker D-Bus service.

Pantheon would be the perfect test bench for this 👍 (though they plan to use tracker in the future)

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Code looks good, needs testing though.

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 24, 2020

I believe if we merge this to gnome-3.38 we'll still get an eval for it? (I think things shouldn't go to staging untested)

@ofborg ofborg bot requested a review from worldofpeace Oct 24, 2020
@jtojnar
Copy link
Contributor Author

@jtojnar jtojnar commented Oct 24, 2020

We need not only eval but also runtime testing, I would wait with this until next staging is merged.

@jtojnar jtojnar marked this pull request as draft Oct 24, 2020
@jtojnar jtojnar closed this Oct 25, 2020
@jtojnar jtojnar deleted the branch NixOS:staging Oct 25, 2020
@jtojnar jtojnar reopened this Oct 31, 2020
@jtojnar jtojnar changed the base branch from gnome-3.38 to staging Oct 31, 2020
jtojnar added 4 commits Nov 26, 2020
It was briefly mentioned in stdenv docs but since it interacts with wrapGAppsHook, it should be documented here.
@jtojnar
Copy link
Contributor Author

@jtojnar jtojnar commented Nov 26, 2020

Running gedit linked against this GTK on Ubuntu, the file chooser seems to work and even search does seem to show some recursive results. Though it does not seem to be complete and complains in the logs:

(gedit:82407): Tracker-CRITICAL **: 22:29:36.021: tracker_sparql_connection_close: assertion 'TRACKER_IS_SPARQL_CONNECTION (connection)' failed

(gedit:82407): Gtk-CRITICAL **: 22:29:36.021: Could not init tracker3 search engine: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.Tracker3.Miner.Files was not provided by any .service files

@jtojnar jtojnar marked this pull request as ready for review Nov 27, 2020
@jtojnar
Copy link
Contributor Author

@jtojnar jtojnar commented Nov 27, 2020

Did not encounter any issues in NixOS VM either.

@jtojnar jtojnar merged commit 136152a into NixOS:staging Nov 28, 2020
19 of 20 checks passed
19 of 20 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
gtk3, gtk3.passthru.tests, tracker, tracker.passthru.tests, wrapGAppsNoGuiHook, wrapGAppsNoGuiHook.passthru.tests on x86_64-darwin
Details
@ofborg[bot]
gtk3, gtk3.passthru.tests, tracker, tracker.passthru.tests, wrapGAppsNoGuiHook, wrapGAppsNoGuiHook.passthru.tests on aarch64-linux Failure
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9596124"; rev="95961244d354246e39fe3e71f4d1a5f0bf7e8ccb"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9596124"; rev="95961244d354246e39fe3e71f4d1a5f0bf7e8ccb"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9596124"; rev="95961244d354246e39fe3e71f4d1a5f0bf7e8ccb"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9596124"; rev="95961244d354246e39fe3e71f4d1a5f0bf7e8ccb"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9596124"; rev="95961244d354246e39fe3e71f4d1a5f0bf7e8ccb"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9596124"; rev="95961244d354246e39fe3e71f4d1a5f0bf7e8ccb"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9596124"; rev="95961244d354246e39fe3e71f4d1a5f0bf7e8ccb"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
gtk3, gtk3.passthru.tests, tracker, tracker.passthru.tests, wrapGAppsNoGuiHook, wrapGAppsNoGuiHook.passthru.tests on x86_64-linux Success
Details
@jtojnar jtojnar deleted the gtk-tracker branch Nov 28, 2020
@jtojnar jtojnar moved this from In Progress to Done in GNOME 3.38 Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment