Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

springlobby: fix build failure #101794

Merged
merged 2 commits into from Oct 27, 2020
Merged

Conversation

@bobvanderlinden
Copy link
Contributor

@bobvanderlinden bobvanderlinden commented Oct 26, 2020

Motivation for this change

The build of springLobby was failing. This PR is intended to resolve a hydra failure of 20.09, part of #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@domenkozar
Copy link
Member

@domenkozar domenkozar commented Oct 27, 2020

@GrahamcOfBorg build springLobby

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 27, 2020

I believe on 20.09 this will be marked broken, so backporting will required to unset that.

@domenkozar domenkozar merged commit 791b40e into NixOS:master Oct 27, 2020
19 of 20 checks passed
@bobvanderlinden
Copy link
Contributor Author

@bobvanderlinden bobvanderlinden commented Oct 27, 2020

@worldofpeace do I need to do something to backport this?

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 27, 2020

Yeah, see CONTRIBUTING.md with how to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants