Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.mirage-block: init at 2.0.1 #101825

Merged
merged 2 commits into from Oct 27, 2020
Merged

Conversation

@vbgl
Copy link
Contributor

@vbgl vbgl commented Oct 27, 2020

Motivation for this change

#23955

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/development/ocaml-modules/mirage-block/default.nix Outdated Show resolved Hide resolved
sha256 = "1wp8wmixaz9i2sbvq6nkx903lbnpdgb2w404pz1wk8kcg9p3ilcc";
};

propagatedBuildInputs = [ cstruct lwt mirage-device ];
Copy link
Member

@SuperSandro2000 SuperSandro2000 Oct 27, 2020

You are sure this are not only build dependencies?

Copy link
Contributor Author

@vbgl vbgl Oct 27, 2020

Yes I am.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Build on darwin:

Result of nixpkgs-review pr 101825 1

1 package built:
  • ocamlPackages.mirage-block

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@cole-h
Copy link
Member

@cole-h cole-h commented Oct 27, 2020

@ofborg eval

@ehmry ehmry merged commit ac97a9a into NixOS:master Oct 27, 2020
16 checks passed
@vbgl vbgl deleted the ocaml-mirage-block-2.0.1 branch Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants