Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

greetd: init at 0.7.0 #102242

Merged
merged 5 commits into from Mar 26, 2021
Merged

greetd: init at 0.7.0 #102242

merged 5 commits into from Mar 26, 2021

Conversation

@luc65r
Copy link
Contributor

@luc65r luc65r commented Oct 31, 2020

Motivation for this change

Wanted to package greetd and friends

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@luc65r luc65r changed the title Pkg/greetd greetd: init at 0.6.1 Oct 31, 2020
@luc65r
Copy link
Contributor Author

@luc65r luc65r commented Oct 31, 2020

Related: #102225
I will do a module later, I'll need some help

@luc65r
Copy link
Contributor Author

@luc65r luc65r commented Oct 31, 2020

Should I move the packages to pkgs/applications/display-managers/?
greetd isn't really a display manager, but it's close...

@tsujp
Copy link

@tsujp tsujp commented Nov 1, 2020

Argh you beat me to greetd!

WRT

Should I move the packages to pkgs/applications/display-managers/?
greetd isn't really a display manager, but it's close...

It does manage the actual session managers and so is a part of that system, I'd say it's fine to put it in display-managers (that's where I had it in my implemented nix package). If you need any assistance let me know (I'm ultra new to Nix so I think you've definitely got this) and I'll see if I can assist :)

Copy link
Member

@mkg20001 mkg20001 left a comment

needs #102225 merged, mobule possibly needs to be moved (where do wayland based DMs go?)

@luc65r luc65r force-pushed the pkg/greetd branch 2 times, most recently from d6ef0b9 to 03f4e08 Dec 27, 2020
@luc65r luc65r changed the title greetd: init at 0.6.1 greetd: init at 0.7.0 Dec 27, 2020
@queezle-net
Copy link
Contributor

@queezle-net queezle-net commented Feb 10, 2021

I will do a module later, I'll need some help

@luc65r I have a module ready to go: greetd.nix.
Would it be ok for you if I create a PR for that?

[...] mobule possibly needs to be moved (where do wayland based DMs go?)

Technically greetd is not wayland-based and makes no assumptions about either the greeter or the session (relevant quote from the docs: "If you can run it from your shell in a TTY, greetd can start it").

That doesn't really make classification easier though. I guess display-managers is fine? There is a hard dependency on PAM, so os-specific/linux would also be correct.

@luc65r
Copy link
Contributor Author

@luc65r luc65r commented Feb 10, 2021

Would it be ok for you if I create a PR for that?

@qzle Sure!
I wrote something, but I've been too lazy to test it.

That doesn't really make classification easier though. I guess display-managers is fine? There is a hard dependency on PAM, so os-specific/linux would also be correct.

That was my reasoning, I guess it doesn't really matter where it is.

@cidkidnix
Copy link

@cidkidnix cidkidnix commented Mar 14, 2021

If possible and agreeable I would put all of the greeters (gtkgreet, wlgreet, etc..) under the greetd. prefix so it the greeters would just be greetd.gtkgreet or greetd.wlgreet, as imo it makes it cleaner in the long run

@devhell
Copy link
Contributor

@devhell devhell commented Mar 21, 2021

Aside from the conflict, what else is stopping this from getting merged?

@luc65r
Copy link
Contributor Author

@luc65r luc65r commented Mar 21, 2021

I would put all of the greeters (gtkgreet, wlgreet, etc..) under the greetd. prefix

Great idea! I will do it as soon as possible.

what else is stopping this from getting merged?

After that, nothing.

pkgs/os-specific/linux/greetd/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/gtkgreet/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/gtkgreet/default.nix Outdated Show resolved Hide resolved
@devhell
Copy link
Contributor

@devhell devhell commented Mar 25, 2021

Wow, @luc65r, that's awesome stuff! Especially adding all those greeters! Fantastic, thank you! 😄

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Mar 25, 2021

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 102242 run on x86_64-linux 1

5 packages built:
  • greetd.dlm
  • greetd.greetd
  • greetd.gtkgreet
  • greetd.tuigreet
  • greetd.wlgreet

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

LGTM

@mkg20001 mkg20001 merged commit 17885fe into NixOS:master Mar 26, 2021
19 checks passed
@lovesegfault
Copy link
Member

@lovesegfault lovesegfault commented Mar 26, 2021

This is awesome @luc65r, looking forward to the modules landing!

@devhell
Copy link
Contributor

@devhell devhell commented Apr 1, 2021

I second @lovesegfault, this is awesome. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants