Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

superTuxKart: 1.1 -> 1.2 #102407

Merged
merged 1 commit into from Dec 14, 2020
Merged

superTuxKart: 1.1 -> 1.2 #102407

merged 1 commit into from Dec 14, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 2, 2020

Motivation for this change

superTuxKart did not build on master since 447edaa because version 1.1 was not compatible with glibc 2.30.

This builds for me, but it doesn't start in sway:



[pbb@onyx:~]$ /nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/bin/supertuxkart
[verbose  ] main: Error messages and other text output will be logged to /home/pbb/.config/supertuxkart/config-0.10/stdout.log.
[error  ] User Config: Unknown value for soccer-player-list; expected true or false
[error  ] User Config: Unknown value for addon-tux-online; expected true or false
[error  ] User Config: Couldn't find parameter group stun-servers-ipv4
[error  ] User Config: Unknown value for enable-network-splitscreen; expected true or false
[error  ] User Config: Unknown value for ipv6-lan; expected true or false
[info   ] [FileManager]: Data files will be fetched from: '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/'
[info   ] [FileManager]: Data files will be fetched from: '/nix/store/awinswl7k10gv160hi3b0rmyp27pgii6-stk-assets/'
[info   ] [FileManager]: User directory is '/home/pbb/.config/supertuxkart/config-0.10/'.
[info   ] [FileManager]: Addons files will be stored in '/home/pbb/.local/share/supertuxkart/addons/'.
[info   ] [FileManager]: Screenshots will be stored in '/home/pbb/.local/share/supertuxkart/screenshots/'.
[info   ] [FileManager]: User-defined grand prix will be stored in '/home/pbb/.local/share/supertuxkart/grandprix/'.
[info   ] [FileManager]: Asset 0 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/challenges/'.
[info   ] [FileManager]: Asset 1 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/gfx/'.
[info   ] [FileManager]: Asset 2 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/grandprix/'.
[info   ] [FileManager]: Asset 3 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/gui/icons/'.
[info   ] [FileManager]: Asset 4 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/gui/screens/'.
[info   ] [FileManager]: Asset 5 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/gui/dialogs/'.
[info   ] [FileManager]: Asset 6 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/replay/'.
[info   ] [FileManager]: Asset 7 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/shaders/'.
[info   ] [FileManager]: Asset 8 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/skins/'.
[info   ] [FileManager]: Asset 9 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/ttf/'.
[info   ] [FileManager]: Asset 10 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/po/'.
[info   ] [FileManager]: Asset 11 will be loaded from '/nix/store/awinswl7k10gv160hi3b0rmyp27pgii6-stk-assets/library/'.
[info   ] [FileManager]: Asset 12 will be loaded from '/nix/store/awinswl7k10gv160hi3b0rmyp27pgii6-stk-assets/models/'.
[info   ] [FileManager]: Asset 13 will be loaded from '/nix/store/awinswl7k10gv160hi3b0rmyp27pgii6-stk-assets/music/'.
[info   ] [FileManager]: Asset 14 will be loaded from '/nix/store/awinswl7k10gv160hi3b0rmyp27pgii6-stk-assets/sfx/'.
[info   ] [FileManager]: Asset 15 will be loaded from '/nix/store/awinswl7k10gv160hi3b0rmyp27pgii6-stk-assets/textures/'.
[info   ] [FileManager]: Asset 16 will be loaded from '/nix/store/awinswl7k10gv160hi3b0rmyp27pgii6-stk-assets/tracks/'.
[verbose  ] translation: Env var LANGUAGE = 'en_US.UTF-8'.
[verbose  ] translation: Language 'English (United States)'.
[info   ] tinygettext: Adding language fallback en

..:: Antarctica Rendering Engine 2.0 ::..
libEGL warning: MESA-LOADER: failed to open radeonsi (search paths /run/opengl-driver/lib/dri)

libEGL warning: MESA-LOADER: failed to open swrast (search paths /run/opengl-driver/lib/dri)

libEGL warning: MESA-LOADER: failed to open swrast (search paths /run/opengl-driver/lib/dri)

[...]

libEGL warning: MESA-LOADER: failed to open radeonsi (search paths /run/opengl-driver/lib/dri)

libEGL warning: MESA-LOADER: failed to open swrast (search paths /run/opengl-driver/lib/dri)

libEGL warning: MESA-LOADER: failed to open swrast (search paths /run/opengl-driver/lib/dri)

[fatal  ] irr_driver: Couldn't initialise irrlicht device. Quitting.


[pbb@onyx:~]$ SDL_VIDEODRIVER=x11 /nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/bin/supertuxkart
[verbose  ] main: Error messages and other text output will be logged to /home/pbb/.config/supertuxkart/config-0.10/stdout.log.
[error  ] User Config: Unknown value for soccer-player-list; expected true or false
[error  ] User Config: Unknown value for addon-tux-online; expected true or false
[error  ] User Config: Couldn't find parameter group stun-servers-ipv4
[error  ] User Config: Unknown value for enable-network-splitscreen; expected true or false
[error  ] User Config: Unknown value for ipv6-lan; expected true or false
[info   ] [FileManager]: Data files will be fetched from: '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/'
[info   ] [FileManager]: Data files will be fetched from: '/nix/store/awinswl7k10gv160hi3b0rmyp27pgii6-stk-assets/'
[info   ] [FileManager]: User directory is '/home/pbb/.config/supertuxkart/config-0.10/'.
[info   ] [FileManager]: Addons files will be stored in '/home/pbb/.local/share/supertuxkart/addons/'.
[info   ] [FileManager]: Screenshots will be stored in '/home/pbb/.local/share/supertuxkart/screenshots/'.
[info   ] [FileManager]: User-defined grand prix will be stored in '/home/pbb/.local/share/supertuxkart/grandprix/'.
[info   ] [FileManager]: Asset 0 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/challenges/'.
[info   ] [FileManager]: Asset 1 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/gfx/'.
[info   ] [FileManager]: Asset 2 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/grandprix/'.
[info   ] [FileManager]: Asset 3 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/gui/icons/'.
[info   ] [FileManager]: Asset 4 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/gui/screens/'.
[info   ] [FileManager]: Asset 5 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/gui/dialogs/'.
[info   ] [FileManager]: Asset 6 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/replay/'.
[info   ] [FileManager]: Asset 7 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/shaders/'.
[info   ] [FileManager]: Asset 8 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/skins/'.
[info   ] [FileManager]: Asset 9 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/ttf/'.
[info   ] [FileManager]: Asset 10 will be loaded from '/nix/store/k1rnm29c2hnxjnzkgwhywj1530whbn95-supertuxkart-1.2/share/supertuxkart/data/po/'.
[info   ] [FileManager]: Asset 11 will be loaded from '/nix/store/awinswl7k10gv160hi3b0rmyp27pgii6-stk-assets/library/'.
[info   ] [FileManager]: Asset 12 will be loaded from '/nix/store/awinswl7k10gv160hi3b0rmyp27pgii6-stk-assets/models/'.
[info   ] [FileManager]: Asset 13 will be loaded from '/nix/store/awinswl7k10gv160hi3b0rmyp27pgii6-stk-assets/music/'.
[info   ] [FileManager]: Asset 14 will be loaded from '/nix/store/awinswl7k10gv160hi3b0rmyp27pgii6-stk-assets/sfx/'.
[info   ] [FileManager]: Asset 15 will be loaded from '/nix/store/awinswl7k10gv160hi3b0rmyp27pgii6-stk-assets/textures/'.
[info   ] [FileManager]: Asset 16 will be loaded from '/nix/store/awinswl7k10gv160hi3b0rmyp27pgii6-stk-assets/tracks/'.
[verbose  ] translation: Env var LANGUAGE = 'en_US.UTF-8'.
[verbose  ] translation: Language 'English (United States)'.
[info   ] tinygettext: Adding language fallback en

..:: Antarctica Rendering Engine 2.0 ::..
X Error of failed request:  BadValue (integer parameter out of range for operation)
  Major opcode of failed request:  151 (XFree86-VidModeExtension)
  Minor opcode of failed request:  1 (XF86VidModeGetModeLine)
  Value in failed request:  0x3cc
  Serial number of failed request:  62
  Current serial number in output stream:  62

[pbb@onyx:~]$

CC @hexchen @spacekookie @Kloenk

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm ryantm marked this pull request as draft November 2, 2020 15:11
pkgs/games/super-tux-kart/default.nix Outdated Show resolved Hide resolved
pkgs/games/super-tux-kart/default.nix Outdated Show resolved Hide resolved
@alyssais
Copy link
Member

Works fine for me with Sway.

@ghost ghost changed the title WIP: superTuxKart: 1.1 -> 1.2 superTuxKart: 1.1 -> 1.2 Dec 14, 2020
@ghost ghost marked this pull request as ready for review December 14, 2020 19:22
@ghost
Copy link
Author

ghost commented Dec 14, 2020

Rebased, tested, runs for me now as well. If anyone with X11 could test as well (@spacekookie maybe?) that would make me confident that it will work for everyone.

@lheckemann
Copy link
Member

It works in Xephyr and Xwayland, IMHO that's good enough 👍

@lheckemann lheckemann merged commit dd95aa3 into NixOS:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants