Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btc1: remove #102652

Merged
merged 1 commit into from Nov 4, 2020
Merged

btc1: remove #102652

merged 1 commit into from Nov 4, 2020

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

Github project is untouched since 2017 and archived since 2019, so we can say it is dead now

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ajs124
ajs124 reviewed Nov 3, 2020
View reviewed changes
pkgs/top-level/aliases.nix Outdated Show resolved Hide resolved
@mmahut
Copy link
Member

mmahut commented Nov 3, 2020

Can you please update release notes?

jonringer
jonringer reviewed Nov 4, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

nixos/doc/manual/release-notes/rl-2103.xml Outdated
@@ -121,6 +121,11 @@
<literal>/var/lib/powerdns</literal> to <literal>/run/pdns</literal>.
</para>
</listitem>
<listitem>
<para>
<package>btc1</package> package removed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually it's nice to say why in notes

Suggested change
<package>btc1</package> package removed.
<package>btc1</package> has been abandoned upstream, and removed.

@mmahut
Copy link
Member

mmahut commented Nov 4, 2020

Thank you.

@mmahut mmahut merged commit 6336ac3 into NixOS:master Nov 4, 2020
@freezeboy freezeboy deleted the remove-btc1 branch November 4, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajs124 ajs124 ajs124 left review comments

@jonringer jonringer jonringer left review comments

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: clean-up 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@freezeboy @mmahut @ajs124 @jonringer