dockerTools: fix absent /proc during runAsRoot #102725
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chroot environment under mnt had /dev and /sys via bind mounts,
but nothing setting up /proc. The
--mount-proc
argument to unsharedefaults to /proc, which is outside of the chroot envirnoment.
Motivation for this change
A recent combination of coreutils/glibc seems to rely on
/proc
during copy for some edge cases, for example, copying a readonly directory. This use case can occur when copying from the store. Motivating test cases:On current master,
vm
anddockerWithProc
should build whiledockerWithoutProc
should fail with:After this change, all cases are expected to pass.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)