Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php: Refactor to have the different versions as separate files #102818

Merged
merged 1 commit into from Nov 7, 2020

Conversation

etu
Copy link
Contributor

@etu etu commented Nov 4, 2020

Motivation for this change

This should enable easier auto updates of the packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu etu force-pushed the php-split-to-leafs branch 2 times, most recently from 6a74312 to 03baf7c Compare November 4, 2020 20:05
@etu etu force-pushed the php-split-to-leafs branch 2 times, most recently from f4d99e6 to 93b87cc Compare November 5, 2020 12:04
@etu etu requested review from aanderse and a team November 5, 2020 20:22
@aanderse
Copy link
Member

aanderse commented Nov 6, 2020

@etu this change looks good 👍 but I haven't had a chance to look in detail what the bot has caught.

@etu
Copy link
Contributor Author

etu commented Nov 6, 2020

It seems like the overrides broke, because it's unit that complains because it attempts to override things...

@etu
Copy link
Contributor Author

etu commented Nov 6, 2020

Some elipsises in the function declarations seems fix it, then I got the same output of unit as before these changes.

This wasn't needed before because we called the default.nix with a very generic set of arguments, then we got the attribute back and did the override on it. Now we call the attribute more directly instead of inheriting it from the output of another function.

This should enable easier auto updates of the packages.
@etu etu merged commit 4d65677 into NixOS:master Nov 7, 2020
@etu etu deleted the php-split-to-leafs branch November 7, 2020 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants