New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plater: init at 2020-07-30 #102995
Merged
Merged
plater: init at 2020-07-30 #102995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovesegfault
force-pushed
the
plater-init
branch
2 times, most recently
from
November 6, 2020 05:36
c3b715c
to
69f2533
Compare
doronbehar
requested changes
Nov 6, 2020
lovesegfault
force-pushed
the
plater-init
branch
from
November 6, 2020 19:51
69f2533
to
cf4c99e
Compare
Made changes, thanks for the review @doronbehar! |
doronbehar
approved these changes
Nov 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me, and I'll merge unless you'd like to wait for flokli's approval.
There's a trailing whitespace at meta.description, other than that, LGTM. Didn't test building or running it, but I assume you did ;-)
|
lovesegfault
force-pushed
the
plater-init
branch
from
November 7, 2020 03:59
cf4c99e
to
5cd0d6d
Compare
@flokli good catch! Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I need this for my 3D printer.
While they do have a 1.0 release that was before they got their build system
working well and fixed some major bugs, so I opted to package the last commit,
which I have tested to work.
cc. @flokli
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)