Reorganize windowmaker dockapps #103050
Merged
Reorganize windowmaker dockapps #103050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkgs/applications/window-managers/windowmaker/dockapps/AlsaMixer-app.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/window-managers/windowmaker/dockapps/AlsaMixer-app.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/window-managers/windowmaker/dockapps/AlsaMixer-app.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/window-managers/windowmaker/dockapps/AlsaMixer-app.nix
Outdated
Show resolved
Hide resolved
| description = "Alsa mixer application for Windowmaker"; | ||
| homepage = "https://www.dockapps.net/alsamixerapp"; | ||
| license = licenses.gpl2Plus; | ||
| maintainers = [ maintainers.bstrik ]; |
There was a problem hiding this comment.
Suggested change
| maintainers = [ maintainers.bstrik ]; | |
| maintainers = with maintainers; [ bstrik ]; |
|
|
||
| dockapps-sources = pkgs.fetchgit { | ||
| url = "https://repo.or.cz/dockapps.git"; | ||
| rev = "b2b9d872ee61c9b329e4597c301e4417cbd9c3ea"; |
There was a problem hiding this comment.
Is there a branch or tag we could track?
There was a problem hiding this comment.
Not so easily. It is essentially a monorepo of a plethora of dockapps.
pkgs/applications/window-managers/windowmaker/dockapps/libdockapp.nix
Outdated
Show resolved
Hide resolved
| description = "A library providing a framework for dockapps"; | ||
| homepage = "https://www.dockapps.net/libdockapp"; | ||
| license = licenses.gpl2Plus; | ||
| maintainers = [ maintainers.bstrik ]; |
There was a problem hiding this comment.
Suggested change
| maintainers = [ maintainers.bstrik ]; | |
| maintainers = with maintainers; [ bstrik ]; |
pkgs/applications/window-managers/windowmaker/dockapps/wmCalClock.nix
Outdated
Show resolved
Hide resolved
Comment on lines
+8
to
+9
| url = "mirror://sourceforge/project/${pname}/${pname}/${pname}-${version}.tar.gz"; | ||
| sha256 = "sha256-jt70NpHp//BxAA4pFmx8GtQgwJVukGgVEGHogcisl+k="; |
There was a problem hiding this comment.
Suggested change
| url = "mirror://sourceforge/project/${pname}/${pname}/${pname}-${version}.tar.gz"; | |
| sha256 = "sha256-jt70NpHp//BxAA4pFmx8GtQgwJVukGgVEGHogcisl+k="; | |
| url = "mirror://sourceforge/project/${pname}/${pname}/${pname}-${version}.tar.gz"; | |
| sha256 = "jt70NpHp//BxAA4pFmx8GtQgwJVukGgVEGHogcisl+k="; |
There was a problem hiding this comment.
Well, this is the format spit out by the command when I use it via fakeSha256 trick.
Most of dockapps live in a monorepo maintained by dockapps.net. Unfortunately there is not an obvious way to fix a particular release, tag or whatever from this monorepo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)