New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ruby-modules gem-config: add exif #103349
Conversation
@@ -179,6 +179,10 @@ in | |||
buildInputs = [ openssl ]; | |||
}; | |||
|
|||
exif = attrs: { | |||
buildFlags = [ "--with-exif-dir=${libexif}" ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this require libexif in buildInputs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are absolutely correct. I wasn't too familiar with nixpkgs at a time of pull request creation. It is fixed now, many thanks.
I marked this as stale due to inactivity. → More info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! sorry for the delay
Motivation for this change
Adding gem-config for the exif gem, which needs libexif in order to be biult.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)