Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-ethereum: 1.9.23 -> 1.9.24 #103697

Closed
wants to merge 1 commit into from
Closed

Conversation

@xwvvvvwx
Copy link
Contributor

@xwvvvvwx xwvvvvwx commented Nov 13, 2020

Motivation for this change

New release: https://github.com/ethereum/go-ethereum/releases/tag/v1.9.24

This is security critical, although we seem to be building with go 1.15.5 on master, so the update is not strictly needed here.

This should be backported, but I'm not sure how to go about it. Afaict go 1.15 is currently only available on master?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@xwvvvvwx xwvvvvwx requested a review from mmahut as a code owner Nov 13, 2020
@xwvvvvwx xwvvvvwx requested review from lionello and adisbladis Nov 13, 2020
@xwvvvvwx
Copy link
Contributor Author

@xwvvvvwx xwvvvvwx commented Nov 13, 2020

oups, missed this somehow: #103653

@xwvvvvwx xwvvvvwx closed this Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant