coreutils, findutils, gnutls: fix build on 32-bit ARM #103925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an upstream patch to fix failing tests. The patch actually affects gnulib, which is included as a vendored dependency.
Add an upstream patch to fix failing tests. The patch actually affects gnulib, which is included as a vendored dependency.
lopsided98
force-pushed
the
coreutils-tests-arm
branch
from
6c0f29c
to
0f5235b
Compare
|
findutils also needs the same patch. I made a copy of the patch, so that we don't have to worry about someone deleting it while another package is still using it. I'm not sure if there are other packages that use gnulib and need this patch. |
lopsided98
changed the title
thefloweringash
approved these changes
Nov 21, 2020
Add an upstream patch to fix failing tests. The patch actually affects gnulib, which is included as a vendored dependency.
lopsided98
changed the title
|
I found that gnutls needs the same fix. |
|
I started an evaluation on my hydra: https://hydra.cons.org.nz/eval/3297?compare=nixpkgs-unstable |
|
only mtdutils seems to be failing |
|
That looks like an unrelated issue. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds an upstream patch to fix tests that fail on 32-bit ARM. The patch actually affects gnulib, which is included as a vendored dependency.
I only applied the patch to 32-bit ARM so this could go in master, but we need to remember to remove it when updating.
cc @edolstra @NeQuissimus @dtzWill
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)