Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nice-dcv-client: init at 2020.2.1737-1 #103939

Merged
merged 2 commits into from Dec 8, 2020
Merged

nice-dcv-client: init at 2020.2.1737-1 #103939

merged 2 commits into from Dec 8, 2020

Conversation

rmcgibbo
Copy link
Contributor

Motivation for this change

This is a client for a remote desktop protocol. I've been using this package on my NixOS machine for a few weeks, and thought it would be better to submit it here. I'm not sure that I've done the expression in the best way or with the best style, so any feedback would be appreciated.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rmcgibbo rmcgibbo force-pushed the nice-dcv branch 2 times, most recently from 931ff33 to 7209d72 Compare November 23, 2020 20:22
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/400

@rmcgibbo
Copy link
Contributor Author

rmcgibbo commented Dec 6, 2020

Thanks for the review, @SuperSandro2000! I'll get this fixed up soon.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103939 run on x86_64-linux 1

1 package built:
  • nice-dcv-client

@rmcgibbo rmcgibbo mentioned this pull request Dec 7, 2020
Merged
10 tasks
@rmcgibbo
Copy link
Contributor Author

rmcgibbo commented Dec 7, 2020

@markuskowa: good suggestion with autopatchelf. I've re-arranged how the phases work according, I think, to what you were suggesting and it's much more concise.

@markuskowa markuskowa merged commit 6d86fa0 into NixOS:master Dec 8, 2020
@rmcgibbo rmcgibbo deleted the nice-dcv branch December 8, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@markuskowa markuskowa markuskowa approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rmcgibbo @nixos-discourse @SuperSandro2000 @markuskowa