Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages: add new 'seccomp' library #103952

Merged

Commits on Nov 20, 2020

  1. pythonPackages: add new 'seccomp' library

    As requested in NixOS#99553. Closes NixOS#99553.
    
    Libraries that install python modules as part of the build are
    problematic, because they either
    
      - only support a single python version, because the input for
        pythonPackages gets fixed in all-packages.nix, or
    
      - need to be rebuild the underlying C code for *every* python version
        resulting in libfoo-python37, libfoo-python38, and so on
    
    We would prefer to use the second approach because it works correctly
    for all versions of python. However, it creates duplicate copies of
    libseccomp.so and that can be expensive. Instead we 'deduplicate' the
    copies of libseccomp.so by
    
      - attaching a new $pythonsrc output to the libseccomp deriv, and
      - exposing a new 'seccomp' package in python-packages.nix using
        libseccomp as input, and
      - having a custom python.nix derivation that builds the cython
        extension using libseccomp to get the python source and the
        package version
    
    This means we build 1 copy of the seccomp python package, one for each
    version of python, but all of those packages refer to a single instance
    of the libseccomp C library, giving us the best of both worlds.
    
    NOTE: because this requires changing the postInstall of libseccomp, it
    requires a mass rebuild.
    
    Signed-off-by: Austin Seipp <aseipp@pobox.com>
    thoughtpolice committed Nov 20, 2020
    Copy the full SHA
    381a368 View commit details
    Browse the repository at this point in the history