Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selinux: 2.9 -> 3.0 #104087

Merged
merged 1 commit into from Nov 20, 2020
Merged

selinux: 2.9 -> 3.0 #104087

merged 1 commit into from Nov 20, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Nov 17, 2020 •
edited

Motivation for this change

Notably, Python 2 code is not be supported in this project anymore and
new Python code should be written only for Python 3, which is no longer
restricted to Python 3.7 (see 780fb56,
5dfd3c4)

https://github.com/SELinuxProject/selinux/releases/tag/20191204

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@raboof
selinux: 2.9 -> 3.0
c3af648 
Notably, Python 2 code is not be supported in this project anymore and
new Python code should be written only for Python 3, which is no longer
restricted to Python 3.7 (see 780fb56,
5dfd3c4)

https://github.com/SELinuxProject/selinux/releases/tag/20191204
@ofborg ofborg bot requested a review from Phreedom November 17, 2020 20:43
@raboof
Copy link
Member Author

raboof commented Nov 18, 2020

Result of nixpkgs-review pr 104087 1

1 package built:
  • glib

@raboof
Copy link
Member Author

raboof commented Nov 18, 2020

Result of nixpkgs-review pr 104087 1

1 package built:
  • systemd

@raboof
Copy link
Member Author

raboof commented Nov 19, 2020

Tested by cherry-picking this patch on top of nixpkgs-unstable (2deeb58) on my desktop machine, with the exception of firefox (which failed to build but that's probably just due to resource exhaustion). I haven't tested any selinux features explicitly, but didn't notice problems either.

@zimbatm
Copy link
Member

zimbatm commented Nov 20, 2020

nix-build nixos/tests/login.nix built successfully

@zimbatm zimbatm merged commit 70ecb21 into NixOS:staging Nov 20, 2020
Atemu added a commit to Atemu/nixpkgs that referenced this pull request Dec 15, 2020
@Atemu
Revert "selinux: 2.9 -> 3.0 (NixOS#104087)"
41aa8d5 
This reverts commit 70ecb21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees
No one assigned
Labels
6.topic: python 6.topic: reproducible builds 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raboof @zimbatm