clamav: enable unit tests, add libjson-c, disable rar explicitly #105074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 1 package built:
|
|
Result of 1 package built:
|
- Add libjson-c dependency for --gen-json functionality.
- Disable rar functionality
- Because it uses non-free software
- Because it doesn't work properly without extra patches
- This didn't work before either, but a warning was added about
failing to load the rar library
- Enable unit tests and add check dependency for that
Mindavi
force-pushed
the
clamav/0.103.0
branch
from
e6e8bd3
to
b7bdab7
Compare
|
Updated with improved wording as suggested. |
SuperSandro2000
requested changes
Dec 8, 2020
|
Result of 1 package built:
|
|
Result of 1 package built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
failing to load the rar library (checked by enabling unit tests for the 0.102.x version).
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc @SuperSandro2000 which has just merged the automated update in #101391