Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elmPackages.elm-review: Init at 2.3.3 #105371

Merged
merged 1 commit into from Dec 3, 2020

Conversation

@turboMaCk
Copy link
Member

@turboMaCk turboMaCk commented Nov 29, 2020

Elm-review is the most advanced linter for elm language. I think we might want to use it for nixos-search.

I had to temporarily generate node-env.nix file for elmPackages as we're waiting for nodePackages to get updated.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
"elm-xref",
"create-elm-app",
"elm-optimize-level-2"
"elm-analyse",
Copy link
Member Author

@turboMaCk turboMaCk Nov 29, 2020

now follows .editorconfig rules

@domenkozar
Copy link
Member

@domenkozar domenkozar commented Nov 29, 2020

@GrahamcOfBorg build elmPackages

nodeEnv = import ../../../node-packages/node-env.nix {
inherit (pkgs) stdenv python2 util-linux runCommand writeTextFile;
nodeEnv = import ./node-env.nix {
inherit (pkgs) stdenv python2 utillinux runCommand writeTextFile;
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 29, 2020

Suggested change
inherit (pkgs) stdenv python2 utillinux runCommand writeTextFile;
inherit (pkgs) stdenv python2 util-linux runCommand writeTextFile;

Copy link
Member Author

@turboMaCk turboMaCk Nov 29, 2020

This file is generated by node2nix. I think this change comes from the new version. If we would revert this, we should also ditch node-env.nix I think.

Copy link
Member Author

@turboMaCk turboMaCk Nov 30, 2020

@domenkozar what do you think about this? Should I edit generated files?

Copy link
Member

@domenkozar domenkozar Dec 3, 2020

I'd keep it as generated and we can fix node2nix to do the right thing.

Copy link
Member Author

@turboMaCk turboMaCk Dec 3, 2020

so in this PR I did not change any of generated file, just regenerated them. This suggestion is to change a file which was generated. This change in how node2nix generates file is also why we now need our own node-env.nix. I'm not sure if anything needs fixing because the newly generated files do work just fine. I think all we would need to avoid creating node-env.nix would be to regenerate nodePackages as well which I don't want to do to keep scope of this change small.

Furthermore I think it'll be better for node2nix maintainers if we would break the dependecy on their node-env.nix for a moment so they can do the transition to new format on their own terms without breaking elmPackages.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

Result of nixpkgs-review pr 105371 run on x86_64-linux 1

5 packages built:
  • elmPackages.create-elm-app
  • elmPackages.elm-analyse
  • elmPackages.elm-language-server
  • elmPackages.elm-review
  • elmPackages.elm-upgrade

garbas
garbas approved these changes Nov 30, 2020
Copy link
Contributor

@garbas garbas left a comment

Looks good to me, but I'll let @domenkozar do the review and merge.

@turboMaCk
Copy link
Member Author

@turboMaCk turboMaCk commented Nov 30, 2020

I'll also open separate PR for marking aarch as bad platform for things that are failing there once this is merged.

@domenkozar domenkozar merged commit 9998527 into NixOS:master Dec 3, 2020
21 of 22 checks passed
21 of 22 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
elmPackages on x86_64-darwin
Details
@ofborg[bot]
elmPackages on aarch64-linux Failure
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
elmPackages on x86_64-linux Success
Details
@ofborg[bot]
elmPackages.elm-review, elmPackages.elm-review.passthru.tests on aarch64-linux Success
Details
@ofborg[bot]
elmPackages.elm-review, elmPackages.elm-review.passthru.tests on x86_64-linux Success
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="200f413"; rev="200f41350fe39589242b78d7b5ce067e94e54b9d"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="200f413"; rev="200f41350fe39589242b78d7b5ce067e94e54b9d"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="200f413"; rev="200f41350fe39589242b78d7b5ce067e94e54b9d"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="200f413"; rev="200f41350fe39589242b78d7b5ce067e94e54b9d"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="200f413"; rev="200f41350fe39589242b78d7b5ce067e94e54b9d"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="200f413"; rev="200f41350fe39589242b78d7b5ce067e94e54b9d"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="200f413"; rev="200f41350fe39589242b78d7b5ce067e94e54b9d"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@turboMaCk turboMaCk deleted the elm-packegse/elm-review branch Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants