Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crow-translate: init at 2.6.2 #105402

Merged
merged 1 commit into from Jan 11, 2021
Merged

crow-translate: init at 2.6.2 #105402

merged 1 commit into from Jan 11, 2021

Conversation

@sikmir
Copy link
Member

@sikmir sikmir commented Nov 29, 2020

Motivation for this change

Crow Translate is a simple and lightweight translator programmed in C++ / Qt that allows to translate and speak text using Google, Yandex and Bing translate API.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 30, 2020

Result of nixpkgs-review pr 105402 run on x86_64-linux 1

1 package built:
  • crow-translate

@sikmir sikmir force-pushed the crow-translate branch from f5fbb72 to ecb69e4 Dec 28, 2020
@sikmir sikmir changed the title crow-translate: init at 2.6.1 crow-translate: init at 2.6.2 Dec 28, 2020
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Jan 2, 2021

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/425

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 11, 2021

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 105402 run on x86_64-linux 1

1 package built:
  • crow-translate

@SuperSandro2000 SuperSandro2000 merged commit 9411c1d into NixOS:master Jan 11, 2021
19 checks passed
@sikmir sikmir deleted the crow-translate branch Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants